There are 9 typeerrors when I load https://crash-stats.mozilla.com/topcrasher/products/Firefox/versions/25.0a1 in FF 25.0a1 (nightly). I've mapped them all back to the following line of unminified code - https://github.com/mozilla/socorro-crashstats/blob/master/crashstats/crashstats/static/crashstats/js/socorro/topcrash.js#L124 The callback in that line is being called with no arguments sometimes. We should make it more robust.
I suspect this was caused by bug 876022
peterbe: "I'd rather we change how we're proxying the mware in the django view code."
Assignee: nobody → peterbe
Status: NEW → ASSIGNED
5 years ago
Duplicate of this bug: 893241
New PR https://github.com/mozilla/socorro-crashstats/pull/428 :rhelmer r?
No longer blocks: 893338
Duplicate of this bug: 893338
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/c0144ae1d4019d03c1a92a8297ee59dcd285a6ed fixes bug 893899 - JS TypeError on TopCrashers https://github.com/mozilla/socorro/commit/b1f75e5bbff9895f64b1ab9f2ea49a2e96a5e759 Merge pull request #1351 from lonnen/pr-428 fixes bug 893899
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Socorro 54 or 55?
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/6d936d1cf671aa76453ab88d4129430ebf17c8c3 fixed bug 893899 https://github.com/mozilla/socorro/commit/23c2b85eece7e7b2336820d1196d5ec8bc6008d2 Merge pull request #1353 from lonnen/bug893899 fixed bug 893899
Because the merge was a bit chaotic as we're moving from socorro-crashstats to socorro, I'll have to refer to the guy who did it all.
(In reply to Scoobidiver from comment #7) > Socorro 54 or 55? It seems it landed on prod, currently Socorro 53.
This landed everywhere.
QA verified on prod - looks great, zero js errors
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
You need to log in before you can comment on or make changes to this bug.