893940 - Intermittent TEST-UNEXPECTED-FAIL | private-browsing-supported/main.testOpenTabWithNonPrivateActiveWindowWithIsPrivateOptionFalse | the tab window and the new window are the same

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This is a new test from bug 893151, failed once on the push that landed it.

TEST-UNEXPECTED-FAIL | private-browsing-supported/main.testOpenTabWithNonPrivateActiveWindowWithIsPrivateOptionFalse | the tab window and the new window are the same
TEST-INFO | Traceback (most recent call last):
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/tabs/observer.js", line 49, in handleEvent
    this._emit(EVENTS[event.type], event.target, event);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/windows/tabs-firefox.js", line 120, in _onTabEvent
    this._emitEvent(type, wrappedTab);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/windows/tabs-firefox.js", line 130, in _emitEvent
    this._tabs._emit.apply(this._tabs, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/tabs/tab-firefox.js", line 129, in _onEvent
    this._emit(type, tab);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://private-browsing-mode-test-at-jetpack/private-browsing-supported/lib/test-tabs.js", line 107, in exports.testOpenTabWithNonPrivateActiveWindowWithIsPrivateOptionFalse/</<.onOpen
    assert.strictEqual(getOwnerWindow(tab), window, 'the tab window and the new window are the same');
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/assert.js", line 204, in strictEqual
    operator: "==="
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/assert.js", line 89, in fail
    this._log.fail(message);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 84, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/harness.js", line 523, in testMessage
    this.trace();
WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 266
++DOMWINDOW == 144 (0xbd3ae38) [serial = 175] [outer = 0xbd86f28]

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1105

Pointer to Github pull-request

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/36309ad65f4668ee2b919607b5c47d4974beba23
Bug 893940 - Intermittent TEST-UNEXPECTED-FAIL | private-browsing-supported/main.testOpenTabWithNonPrivateActiveWindowWithIsPrivateOptionFalse

https://github.com/mozilla/addon-sdk/commit/688f6b03f12f3ca2e61d143e0e5454c3c3775c0f
Merge pull request #1105 from erikvold/893940

Bug 893940 - Intermittent TEST-UNEXPECTED-FAIL | private-browsing-supported/main.testOpenTabWithNonPrivateActiveWindowWithIsPrivateOptionFalse r=@jsantell

Comment 4

[Dave Townsend [:mossop]]

So fixed?