Closed Bug 893968 Opened 7 years ago Closed 7 years ago

LaunchState locking isn't actually locking anything useful

Categories

(Firefox for Android :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 25

People

(Reporter: blassey, Unassigned)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Kats noticed this bug in a review from some other patch (I think starting gecko sooner). Pushed to try:

https://tbpl.mozilla.org/?tree=Try&rev=bf500f68376a
Attachment #775845 - Flags: review?(bugmail.mozilla)
Comment on attachment 775845 [details] [diff] [review]
patch

Review of attachment 775845 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoThread.java
@@ +120,4 @@
>          GeckoAppShell.runGecko(path, args, mUri, type);
>      }
>  
> +    static Object sLock = new Object();

Make this private.
Attachment #775845 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/e4e605d990f4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.