894045 - Gamepad support for search suggestions

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Bug 876765 needs to be ported to fig so a game controller can be used to navigate search suggestions.

Comment 1

[:Margaret Leibovic]

I just merged m-c into fig, and I punted on properly merging over the changes from bug 876765, but we should now be able to go ahead and port over that functionality without worrying about more conflicts.

Part of the problem was that on fig there was already a home/SearchEngineRow class, and I didn't want to try to manually go through the SearchEngineRow class on m-c to compare exactly what changes needed to make their way over.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Add gamepad support for search suggestions

Pretty much just a copy/paste from central.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 781300 [details] [diff] [review]
Add gamepad support for search suggestions

Review of attachment 781300 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: mobile/android/base/home/BrowserSearch.java
@@ +232,5 @@
> +
> +        mList.setOnKeyListener(new View.OnKeyListener() {
> +            @Override
> +            public boolean onKey(View v, int keyCode, android.view.KeyEvent event) {
> +                View selected = mList.getSelectedView();

final

@@ +235,5 @@
> +            public boolean onKey(View v, int keyCode, android.view.KeyEvent event) {
> +                View selected = mList.getSelectedView();
> +
> +                if (selected instanceof SearchEngineRow) {
> +                    return ((SearchEngineRow) selected).onKeyDown(keyCode, event);

Do you really need this casting here? AFAIK, onKeyDown is part of View's API.

Comment 4

[Brian Nicholson (:bnicholson)]

(In reply to Lucas Rocha (:lucasr) from comment #3)
> @@ +235,5 @@
> > +            public boolean onKey(View v, int keyCode, android.view.KeyEvent event) {
> > +                View selected = mList.getSelectedView();
> > +
> > +                if (selected instanceof SearchEngineRow) {
> > +                    return ((SearchEngineRow) selected).onKeyDown(keyCode, event);
> 
> Do you really need this casting here? AFAIK, onKeyDown is part of View's API.

Nope, good catch.

https://hg.mozilla.org/projects/fig/rev/962211a2b765

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/962211a2b765