894081 - Register Gaia's mozbrowsererror on the relevant iframe itself, to (try to) fix a leak

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Justin Lebar (not reading bugmail)]

See discussion in bug 893012 comment 22 and nearby.

Filing this in a separate bug because the defect identified in bug 893012 may involve many small fixes all around gecko and gaia.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10991

Pointer to Github pull-request

Comment 2

[Justin Lebar (not reading bugmail)]

This PR also includes bug 894135, another leak-fix.  I confirmed that we do in fact need both changes.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 775992 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10991

r+, thanks

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

merged
https://github.com/mozilla-b2g/gaia/commit/d85dbb240e000903c9cb0a7a1f8aff45b3592e28

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

There's a regression in fix of 894135. Warm boot timing measurement is failing.
Root cause: When event type is 'appopen' to be watched, the event target is frame instead of iframe.

I am going to fix this in another bug.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted d85dbb240e000903c9cb0a7a1f8aff45b3592e28 to:
v1-train: 3724c21c68f88169a443e2a5636b65b4a4a58f59

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

I think we have to uplift https://bugzilla.mozilla.org/show_bug.cgi?id=894230 as well.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 3724c21c68f88169a443e2a5636b65b4a4a58f59