Closed
Bug 894181
Opened 11 years ago
Closed 11 years ago
Convert a bunch of SHAPE_* macros to inline functions to eliminate warnings, enhance debuggability
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
2.74 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
This eliminates another batch of clang+ccache warnings.
Attachment #776114 -
Flags: review?(terrence)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 776114 [details] [diff] [review] Patch Review of attachment 776114 [details] [diff] [review]: ----------------------------------------------------------------- Maybe move these to sanely named members of Shape as a followup? r=me ::: js/src/vm/Shape.h @@ -1044,4 @@ > SkipRoot skip; > MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER > }; > - }; Heh, wonder when that snuck in.
Attachment #776114 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/99217132cccc
Target Milestone: --- → mozilla25
https://hg.mozilla.org/mozilla-central/rev/99217132cccc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•