894287 - [Buri][Call]The previous call process will disappear when you dial another call on passcode lock screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.152
 Firefox os  v1.1
 Mozilla build ID:20130702230206
 
 DEFECT DESCRIPTION:
 The previous call process will disappear when you dial another call on passcode lock screen
 
 REPRODUCING PROCEDURES:
 1.enable passcode lock
 2.make a call(10010)->during the call->press the home key to background
 3.press power key to lock screen->wake and unlock the screen
 4.on passcode lock screen->enter Emergency Call dialer
 5.dial another call(10086)->The previous call process will disappear,but the call sound still exist.==>KO.
 
  EXPECTED BEHAVIOUR:
 The "Emergency Call" button should change to "Return the call" button when
 one call established
 Please follow android phone's behavior
 It should not be allowed to dial any calls when one call established on the passcode lock screen
 
 ASSOCIATE SPECIFICATION:
 TEST PLAN REFERENCE:
 TOOLS AND PLATFORMS USED:
 USER IMPACT:
 REPRODUCING RATE:5/5
 For FT PR, Please list reference mobile's behavior:
 
 Li Xin
 Tel:[phone]

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I found mozTelephony.calls becomes empty unexpectedly after performing the STR above.

The diff below exposes where things goes wrong:
https://gist.github.com/rexboy7/6027881

After performing STR I get the log below:
app://system.gaiamobile.org/emergency-call/js/dialer.js:19 in callEnded: system_ondisconnected_current calls:1
app://system.gaiamobile.org/emergency-call/js/dialer.js:21 in print: --117
app://communications.gaiamobile.org/dialer/js/oncall.js:282 in handledCallIterator: current calls:0

As you can see at the last line, mozTelephony.calls.length becomes 0 while there is still a call (which is 117 in my test case) connected.

Hsin-Yi do you have any idea or can any other help on this?
Thanks!

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to KM Lee [:rexboy] from comment #2)
> I found mozTelephony.calls becomes empty unexpectedly after performing the
> STR above.
> 
> The diff below exposes where things goes wrong:
> https://gist.github.com/rexboy7/6027881
> 
> After performing STR I get the log below:
> app://system.gaiamobile.org/emergency-call/js/dialer.js:19 in callEnded:
> system_ondisconnected_current calls:1
> app://system.gaiamobile.org/emergency-call/js/dialer.js:21 in print: --117
> app://communications.gaiamobile.org/dialer/js/oncall.js:282 in
> handledCallIterator: current calls:0
> 
> As you can see at the last line, mozTelephony.calls.length becomes 0 while
> there is still a call (which is 117 in my test case) connected.
> 
> Hsin-Yi do you have any idea or can any other help on this?
> Thanks!

Regarding the weird calls length read in oncall.js, the root cause is Bug 837079. I have some thoughts there.

However, according to comment #0, looks like we have two different issues here.
1) We should *not* let user dial any calls when one call established on the passcode lock screen. The "Emergency Call" button should change to "Return the call" button when one call established. This is our expected behaviour.
2) Once we accidentally let user be able to dial a call via emergency_dialer when there's already a call (our current UI but contradicts 1) ), the call screen is wiped out unexpectedly. Bug 837079 should solve this.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I agree with Hsin-Yi in Comment #3.

But as now, l10n changes are frozen and we would need a late-l10n process to implement the "Return to the call" button. Is it ok if we just disable the "Emergency call" button when there is a call? Users can still return to the call by tapping the green bar at top of the screen.

ni UX team.

Comment 5

[Stephany Wilkes]

Assigning to Francis.

Comment 6

[Francis Djabri [:djabber]]

I  suggest that we put in a late-l10n request to change the string to "Return to call" if possible. 

If this process fails, then please keep the string as "Emergency call" but pressing this button should still return the user to the call, rather than allow the user to start a new one.

Comment 7

[Stephany Wilkes]

Adding late-l10n keyword for triage.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

To sum up, this patch changes functionality of "Emergency call" button slightly.
When there are connected calls, the button turns into "Return to call", and thus we
need to do late-l10n review for the "Return to call".

Tim and Pike may you help review this patch? Thank a lot!

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Screenshot

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 782533 [details]
Screenshot

This carries a *high* risk of regressions, looking at the amount of visual space. An idea would be the following pseudo localization: "_Řḗŧŭřƞ_ _ŧǿ_ _Ƈȧŀŀ_"

I'm not sure this is UX that can work in general.

I'm concerned about the text transform for greek, too.

ȦƁƇḒḖƑƓĦĪĴĶĿḾȠǾƤɊŘŞŦŬṼẆẊẎẐ" + u"[\\]^_`" + u"ȧƀƈḓḗƒɠħīĵķŀḿƞǿƥɋřşŧŭṽẇẋẏẑ

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 782532 [details]
patch

r-, I don't think the UX will work with localizations. In particular not on short notice as we'd need it for 1.1.

Comment 12

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Per comment 10. and 11., I'm not sure what to do now.
Should we leo- this bug or try another workaround?

ni? ux and leo.

Comment 13

[Leo]

We think this issue is very critical. 
So, this issue should be fixed.

Comment 14

[Stephany Wilkes]

Flagging Francis. The situation for UX to advise on appears to be that our recommended UX won't work with localization. I'm not sure if we can suggest other workarounds, but flagging Francis just in case there's an alternative. Francis, please reassign as necessary/appropriate.

Comment 15

[Francis Djabri [:djabber]]

If the localization change can't take effect, I'm happy to go with the recommendation that KM Lee recommended in comment 4.

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 782532 [details]
patch

r+ the code, this does not meant to overwrite r- from :l10n.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Sorry about the delay.

Comment 18

[bhavana bajaj [:bajaj]]

Needsinfo KM lee to address comment 15, is there an alternate patch coming ?

Comment 19

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 782532 [details]
patch

Patch revised.

Per comment 15. This patch just disable the "emergency call" button when on call
rather than switching to "return to call", so it's simpler and doesn't need l10n
changes. (Therefore removing l10n review)

Sorry Tim, because I changed the behavior, may you review it again? The patch works
just about the same way excluding that "return to call" feature is removed.
Thanks a lot!

Comment 20

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thank you Tim!

master
https://github.com/mozilla-b2g/gaia/commit/a510db486c336a8090d6888f3e50cfb3a5c468e9

Comment 21

[Leo]

Dear KM Lee.
Please land this patch to v1-train

Comment 22

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 a510db486c336a8090d6888f3e50cfb3a5c468e9
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 23

[KM Lee [:rexboy] (inactivate after Sep. 22)]

v1-train
https://github.com/mozilla-b2g/gaia/commit/df57dcec720493bedff4601499d78c147ad7d253

v1.1.0hd
https://github.com/mozilla-b2g/gaia/commit/e6bab78f761eed7d96a0c91b14f7c34a5798052a

Comment 24

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: df57dcec720493bedff4601499d78c147ad7d253

Comment 25

[Jeni]

Verified fixed

Build ID: 20130815041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/692d3414bb12
Gaia: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d
Platform Version: 18.1
RIL Version: 01.01.00.019.190 

Now works as comment 19 stated...  Emergency call has been disabled when user is in a call