Closed Bug 894311 Opened 11 years ago Closed 11 years ago

Finding a string with ':' breaks scripts list

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: Gijs, Assigned: vporof)

References

Details

Attachments

(2 files)

STR: 1. Open the (browser?) debugger 2. Select a file that has methods on objects declared thus: foo: function() { 3. Hit accel-f, and start typing your favourite method declared in such a manner. ER: Scripts list is fine throughout AR: Once you type the colon, the scripts list goes blank. This makes me sad.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P3
Attachment #801412 - Flags: review?(rcampbell)
Attachment #801413 - Flags: review?(rcampbell)
Depends on: 886848, 876277, 891439, 881219
Blocks: 876633
Comment on attachment 801412 [details] [diff] [review] dbg-filter-semicolon.patch Review of attachment 801412 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/debugger/debugger-toolbar.js @@ +744,5 @@ > this._tokenSearchKey = LayoutHelpers.prettyKey(document.getElementById("tokenSearchKey"), true); > this._lineSearchKey = LayoutHelpers.prettyKey(document.getElementById("lineSearchKey"), true); > this._variableSearchKey = LayoutHelpers.prettyKey(document.getElementById("variableSearchKey"), true); > > + this._searchbox.addEventListener("mouseup", this._onClick, false); We're changing this to mouseup? Why?
Attachment #801412 - Flags: review?(rcampbell) → review+
Comment on attachment 801413 [details] [diff] [review] dbg-filter-semicolon-tests.patch Review of attachment 801413 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/debugger/test/browser_dbg_search-basic-03.js @@ +19,5 @@ > + gDebugger = gPanel.panelWin; > + gSources = gDebugger.DebuggerView.Sources; > + gSearchBox = gDebugger.DebuggerView.Filtering._searchbox; > + > + waitForSourceAndCaretAndScopes(gPanel, "-02.js", 6) why not, "waitForEverything()"? lol
Attachment #801413 - Flags: review?(rcampbell) → review+
(In reply to Rob Campbell [:rc] (:robcee) from comment #5) > Comment on attachment 801412 [details] [diff] [review] > > We're changing this to mouseup? Why? Accidental leftover from trying to fix bug 876633. Good catch.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: