Closed
Bug 894311
Opened 11 years ago
Closed 11 years ago
Finding a string with ':' breaks scripts list
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: Gijs, Assigned: vporof)
References
Details
Attachments
(2 files)
22.94 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
16.21 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
STR:
1. Open the (browser?) debugger
2. Select a file that has methods on objects declared thus:
foo: function() {
3. Hit accel-f, and start typing your favourite method declared in such a manner.
ER:
Scripts list is fine throughout
AR:
Once you type the colon, the scripts list goes blank. This makes me sad.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #801412 -
Flags: review?(rcampbell)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #801413 -
Flags: review?(rcampbell)
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 3•11 years ago
|
||
The amount dependent patches to test this out is pretty high. Get your builds from here: https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/vporof@mozilla.com-fefd4e522879/
Try: https://tbpl.mozilla.org/?tree=Try&pusher=vporof@mozilla.com
Assignee | ||
Comment 4•11 years ago
|
||
Actual try link: https://tbpl.mozilla.org/?tree=Try&rev=fefd4e522879
Comment 5•11 years ago
|
||
Comment on attachment 801412 [details] [diff] [review]
dbg-filter-semicolon.patch
Review of attachment 801412 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/debugger/debugger-toolbar.js
@@ +744,5 @@
> this._tokenSearchKey = LayoutHelpers.prettyKey(document.getElementById("tokenSearchKey"), true);
> this._lineSearchKey = LayoutHelpers.prettyKey(document.getElementById("lineSearchKey"), true);
> this._variableSearchKey = LayoutHelpers.prettyKey(document.getElementById("variableSearchKey"), true);
>
> + this._searchbox.addEventListener("mouseup", this._onClick, false);
We're changing this to mouseup? Why?
Attachment #801412 -
Flags: review?(rcampbell) → review+
Comment 6•11 years ago
|
||
Comment on attachment 801413 [details] [diff] [review]
dbg-filter-semicolon-tests.patch
Review of attachment 801413 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/debugger/test/browser_dbg_search-basic-03.js
@@ +19,5 @@
> + gDebugger = gPanel.panelWin;
> + gSources = gDebugger.DebuggerView.Sources;
> + gSearchBox = gDebugger.DebuggerView.Filtering._searchbox;
> +
> + waitForSourceAndCaretAndScopes(gPanel, "-02.js", 6)
why not, "waitForEverything()"? lol
Attachment #801413 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> Comment on attachment 801412 [details] [diff] [review]
>
> We're changing this to mouseup? Why?
Accidental leftover from trying to fix bug 876633. Good catch.
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f45580c36618
https://hg.mozilla.org/integration/fx-team/rev/7b74e2d12cf7
Whiteboard: [fixed-in-fx-team]
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f45580c36618
https://hg.mozilla.org/mozilla-central/rev/7b74e2d12cf7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•