894349 - Sort permissions in the site identity panel and the page info window alphabetically

Status: VERIFIED FIXED

(Firefox :: General, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

This excludes plugin permissions in the page info window, as those aren't handled by SitePermissions.jsm yet.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 776338 [details] [diff] [review]
patch

Review of attachment 776338 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Dão Gottwald [:dao] from comment #0)
> This excludes plugin permissions in the page info window, as those aren't
> handled by SitePermissions.jsm yet.

These are however sorted by the current code at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/pageinfo/permissions.js#301 with the exception that the current code doesn't use localeCompare.

Comment 2

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f38845197c8b

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f38845197c8b

Comment 4

[Bogdan Maris, Desktop QA]

Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0

Verified fixed in latest Aurora and latest Nightly on Windows 7 x64, Mac OS X 10.8 and Ubuntu 12.04 x32.