Closed Bug 894349 Opened 6 years ago Closed 6 years ago

Sort permissions in the site identity panel and the page info window alphabetically

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

VERIFIED FIXED
Firefox 25

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This excludes plugin permissions in the page info window, as those aren't handled by SitePermissions.jsm yet.
Attachment #776338 - Flags: review?(jaws)
Comment on attachment 776338 [details] [diff] [review]
patch

Review of attachment 776338 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Dão Gottwald [:dao] from comment #0)
> This excludes plugin permissions in the page info window, as those aren't
> handled by SitePermissions.jsm yet.

These are however sorted by the current code at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/pageinfo/permissions.js#301 with the exception that the current code doesn't use localeCompare.
Attachment #776338 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/f38845197c8b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0

Verified fixed in latest Aurora and latest Nightly on Windows 7 x64, Mac OS X 10.8 and Ubuntu 12.04 x32.
Status: RESOLVED → VERIFIED
QA Contact: bogdan.maris
You need to log in before you can comment on or make changes to this bug.