894421 - If the user tries to install a paid app the application will still continue to display the install button even though the installation was successful

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect)

Description

[sailajan.sabaratnam]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130618035212

Steps to reproduce:

1. Launch MP.
2. Search for a pricetier.
3. Buy the app.
4. Install the app from the install page.


Actual results:

Notice the user is redirected to the app details page and the install button is still shown.


Expected results:

The user should not see the install button again.

Comment 1

[sailajan.sabaratnam]

Attachment: The "Install" button does not change to "Launch" unless the user navigates away from that screen

Comment 2

[sailajan.sabaratnam]

Attachment: log

Comment 3

[Matt Basta [:basta]]

I'm unable to reproduce this issue. Please reproduce and submit your logs so it can be debugged further:

https://github.com/mozilla/fireplace/tree/master/ashes#submitting-logs

Comment 5

[Vikas Nanda]

(In reply to Matt Basta [:basta] from comment #3)
> I'm unable to reproduce this issue. Please reproduce and submit your logs so
> it can be debugged further:
> 
> https://github.com/mozilla/fireplace/tree/master/ashes#submitting-logs

ID: ea2a2

Comment 6

[Matt Basta [:basta]]

I figured this out. It's because we're doing a views.reload() and not re-binding the buttons. I'll fix soon.

Comment 8

[Matt Basta [:basta]]

This should fix it, but I have no real way to test at the moment. If someone could check, that would be fantastic.</rockstar>

https://github.com/mozilla/fireplace/commit/b3d8060b5a57c24b3ddc235a0bf0191a1ad763a7

Comment 9

[krupa raj[:krupa]]

I can still reproduce this issue on dev. ashes: fbb2b

Comment 12

[Matt Basta [:basta]]

https://github.com/mozilla/fireplace/commit/9fc9cfbf11eaece25511761c54b19628b507ab69

The fix for real this time. Note that this slightly impacts bug 838848, but nobody will ever notice (it's fine).

Comment 13

[Matt Basta [:basta]]

To explain why this happens:

We were calling `views.reload()` to reload the page after purchase. This allows reviews-related controls to correct themselves. The downside is that the button that we have a reference to gets blasted away into the ether and replaced with a new button. The solution here was to simply perform the reload on the resolution of the button's deferred rather than on the payments flow's deferred. That means that while the user is interacting with the buttons/door hangers the reviews will be in a weird state, but by the time anybody notices or can scroll down it should have fixed itself.

Comment 14

[Iulian Timis]

Verified as fixed in MP-dev app (Unagi).
The install button now has its label changed to "Launch" after the app is installed.
Closing bug.