894462 - servo build slaves need libpng

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Jack Moffitt [:jack]]

libpng was recently added as a Servo dependency, but it doesn't seem to exist on either build mac or linux build slaves.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: install libpng

Linux is taken care of by Mozharness. This patch should do it.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 776478 [details] [diff] [review]
install libpng

Should be fixed for Linux now.

Comment 3

[[e-mail] (:bhearsum)]

Dustin, any idea how to install this on Mac? Jack says he uses libpng from "brew" locally, but I suspect we can't use brew on the build machines.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

You'll need to build a pkgdmg.  It shouldn't be too difficult, based on the other scripts in modules/packages/manifests/*-dmg.sh

Comment 5

[[e-mail] (:bhearsum)]

Linux build still failed due to a missing symbol:
11:17:20     INFO -  note: /builds/slave/linux/build/objdir/src/support/png/rust-png/libpng-102129e09d96658-0.1.so: undefined reference to `png_set_longjmp_fn'
11:17:20     INFO -  collect2: ld returned 1 exit status

Jack, is this something you can work around? libpng 1.2.46 is the latest that's available in CentOS 6.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: libpng puppet stuff

This is based on the yasm stuff. I had to use `pwd`/installroot in "make install" because libpng is fussy about having an absolute dir. DMG installed fine by hand.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 776588 [details] [diff] [review]
libpng puppet stuff

Review of attachment 776588 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, assuming it's OK to install libpng on *all* Darwin build slaves, including moco.

Comment 8

[[e-mail] (:bhearsum)]

(In reply to Dustin J. Mitchell [:dustin] from comment #7)
> Comment on attachment 776588 [details] [diff] [review]
> libpng puppet stuff
> 
> Review of attachment 776588 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, assuming it's OK to install libpng on *all* Darwin build slaves,
> including moco.

Yup, my intent has always been to keep Servo and non-Servo slaves the same.

Comment 9

[Jack Moffitt [:jack]]

I've got a patch for libpng 1.2 support. Will retry the build shortly.

Comment 10

[Jack Moffitt [:jack]]

I now get 

/usr/include/pngconf.h:390: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘.’ token

on the linux slave. :(

Comment 11

[Jack Moffitt [:jack]]

It works now with some additional fixes to rust-png.

Comment 12

[[e-mail] (:bhearsum)]

I've seen Servo and non-Servo slaves grab the libpng package without issue -> FIXED. I did notice bug 894907 in the process, though, which makes us need to manually reboot the Mac Servo slaves whenever we make a Puppet change.