894480 - TBPL should only show bug suggestions for bugs modified in the last 3 months

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Currently TBPL uses bzapi requests of the form:
https://api-dev.bugzilla.mozilla.org/latest/bug?keywords=intermittent-failure&include_fields=id,summary,status,resolution&summary=
...to populate the list of bug suggestions for a particular failure.

This means:
a) The annotated summary is often pretty full of old, closed out & unhelpful bugs (particularly for say webgl failures).
b) It's pretty tempting to reopen bugs rather than file a new one, even though enough time has passed that it's likely actually a new failure mode.

As such, we should only show bugs that have a modified time in the last N months. I'd suggest setting N at 3 initially, and we can see how we go from there.

What do you all think? :-)

Comment 1

[Ed Morley [:emorley]]

As an example:

https://api-dev.bugzilla.mozilla.org/latest/bug?keywords=intermittent-failure&include_fields=id,summary,status,resolution&summary=test_webgl_conformance_test_suite.html

vs

https://api-dev.bugzilla.mozilla.org/latest/bug?keywords=intermittent-failure&include_fields=id,summary,status,resolution&summary=test_webgl_conformance_test_suite.html&changed_after=-3m

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Only suggest bugs that have been modified in the last 3 months.

(Only attaching here for reference, would like feedback from everyone before we proceed).

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Completely agree.

Comment 4

[Ed Morley [:emorley]]

Attachment: Patch v1a

(This time without debugging hunk from bug 887313)

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 776510 [details] [diff] [review]
Patch v1a

With no objections, let's go with 3 months for now :-)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 776510 [details] [diff] [review]
Patch v1a

\o/

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/webtools/tbpl/rev/26fcd190e0f6

Comment 8

[Ed Morley [:emorley]]

In production :-)

Comment 9

[Ed Morley [:emorley]]

This has made quite an improvement to the test_reftests_with_caret.html results! :-)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

And the various test_ipc failures. Very noticeable!