Existing learning projects use odd links for web fonts

RESOLVED FIXED

Status

Webmaker
Thimble
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: brett, Assigned: pomax)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
As an example:
      @font-face {
        font-family: 'Lobster';
        font-style: normal;
        font-weight: 400;
        src: local('Lobster'), url(http://themes.googleusercontent.com/https://webpagemaker-dev.allizom.org/sd/gallery/fonts/lobster/v5/NIaFDq6p6eLpSvtV2DTNDQLUuEpTyoUstqEm5AMlJo4.woff) format('woff');
      }

We need to replace with 
<link href='http://fonts.googleapis.com/css?family=Lobster' rel='stylesheet' type='text/css'>

in the <head>
(Assignee)

Comment 1

5 years ago
Created attachment 783947 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/192

These were the only @font-face rules I could find in our old learning projects.
Attachment #783947 - Flags: review?(brett)
(Assignee)

Updated

5 years ago
Attachment #783947 - Flags: review?(brett)

Comment 2

5 years ago
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/caac1a40b07f2e9aff4571bd763a54febe562ef4
Merge pull request #192 from Pomax/bug894580

switched @font-face rules to <link>
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.