89463 - When I send a message I get a copy of the message in my temp directory

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[msanz]

Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.2) Gecko/20010705 Netscape6/6.1 
using POP
When I send a message, I get a copy of it in my temp directory. My preferences
are set to store a copy in my sent folder, not to temp.

Comment 1

[Scott MacGregor]

.

Comment 2

[msanz]

Attachment: all files created and kept in temp when sending a new message

Comment 3

[Sheela Ravindran]

using build id:  2001070604 
I see this problem on win98 too. Every message sent and received leaves a copy 
in the windows temp folder. This is including a text mssg, mssg sent with 
attachment too.  Temp folder might really get too big very soon. There should be 
no need to keep a copy of the message that gets sent in the temp folder.  
There was a bug regarding forwarding emails with attachments did not clean up 
temp folder which was fixed a while ago. But now it could be even a simple text 
message too.  
I did not see anything getting created when sending from an imap account and 
only in pop.

Comment 4

[doctor__j]

Sounds to me that this would be cause a security issue.

Comment 5

[scottputterman]

Cavin, could you look into this since you solved a number of the other temp
message bugs.

Comment 6

[Jean-Francois Ducarroz]

I see this leak only when you have a copy to a local folder set in the account
manager. The problem wont occur if you turn of the copy of set a copy to an imap
folder.

Comment 7

[Cavin Song]

Yes, this happens only when the sent folder is on local.  I figured out where 
the problem is:

In nsMsgLocalMailFolder::EndCopy(),

  copyService->NotifyCompletion(srcSupport, this, rv);

doesn't get called if 'listener' is set. As a result, the refcnts for some of 
the objects are not decremented, especially the one for nsMsgComposeAndSend 
because we remove temp files in the destructor of nsMsgComposeAndSend.

Navin, I remeber you changed the code to fix bug #75936 (I think) initially and 
we had to change it to the way it's now to fix bug #85921 (save draft to local 
doesn't work). Now it seems like that the fix breaks this case again, so let's 
talk about it tomorrow to come out with a solution which would fix all 3 
scenarios.

Comment 8

[Cavin Song]

Navin and I have come out with a fix for all 3 scenarios. Need more testing 
before checking in the code.  Reassign it to Navin.

Comment 9

[scottputterman]

adding nsbranch as a possiblity.

Comment 10

[Navin Gupta]

Attachment: proposed fix

Comment 11

[Navin Gupta]

So I have tested online stuff from 3 pane and search window for move/copy 
from menus and D&D where destination is imap and src is news imap and local.
Also cavin has tested all compose scenarios. Offline stuff yet to be tested. 

The fix is to remove the copyService use from the compose code and directly 
call copy on destFolder. Also remove mCopylistener from the imapMailFolder and 
use the copy of listener in copyState, because this introduces a leak and tmp 
files are not deleted. cc bienvenu for review. 

Comment 12

[scottputterman]

If you get the reviews, it would be great to get it on the trunk in time for
tomorrow's build.  Then we really need to test this!

Comment 13

[David :Bienvenu]

r=bienvenu, but really only testing will determine if this fix works. I think
even things like compacting offline stores will need to be tested here, as well
as offline copy, etc.

Comment 14

[Navin Gupta]

fix checked on trunk. 
checked offline imap copy and compactofflineStores still works. 

Comment 15

[Oliver Klee]

*** Bug 89776 has been marked as a duplicate of this bug. ***

Comment 16

[Oliver Klee]

*** Bug 90713 has been marked as a duplicate of this bug. ***

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

Things Sheela and I have tested for (Sheela tested Win98, I tested Mac OS 9.1
and RedHat Linux 7.1):

On all of these operations, we tested Copy and Move, seperately:

News -> IMAP, News -> Local, IMAP -> Local, IMAP -> IMAP, File Carbon Copy to
Local, FCC to IMAP, Templates (local/IMAP), Drafts (local/IMAP).  Navin says
this code won't affect POP, but Offline I still need to test.

We used context menus, File menus, and Drag & Drop.

Builds we used were:

Mac OS 9.1 - 2001-07-13-09
RedHat 7.1 - 2001-07-13-08
Windows 98 - 2001-07-13-04

I believe we also need to explicitly test now for Offline & the presence/absence
of the Temp files.  

Those will be in:

Windows - C:\<OS install dir>\Temp or C:\<OS install dir>\ TMP (or, user defined)

Linux - /home/username/tmp (and possibly in sub-dirs)

Mac OS - Probably in the user's profile?  I'm not sure though.

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

Okay, going offline, doing a copy, and then going back online and reading the 
message works fine on the builds/platforms mentioned above.

Comment 19

[esther]

OK, we making this trunkverified

Comment 20

[lchiang]

pdt+ per pdt email.
navin, when you mark this fixed, please remove the vtrunk keyword. Thanks.

Comment 21

[rubydoo123]

Can this be checked in on the branch today?

Comment 22

[Navin Gupta]

sure, I will do it today. 

Comment 23

[Navin Gupta]

fix checked in. 

Comment 24

[[e-mail] (gone - use [e-mail] instead)]

Cool.  This is fine so far (haven't tested Mac yet).  No temp files exist in:

C:\WINNT\temp  on Windows 2000 using build 2001-07-17-05-0.9.2
/home/stephend/tmp on RedHat Linux 7.1 using build 2001-07-07-04-0.9.2

Any ideas on how to check Macintosh?  Aren't they invisible files or something?
 (Have to check using some Sherlock 2 foo, I'm sure.)

Comment 25

[Jean-Francois Ducarroz]

On the mac, the "temporary items" folder is automatically flushed when the computer start. The only way to check 
with Sherlock, is to now part of the filename you are looking for.

Comment 26

[[e-mail] (gone - use [e-mail] instead)]

That linux build above should've been: 2001-07-17-04-0.9.2

Comment 27

[[e-mail] (gone - use [e-mail] instead)]

Is that even possible to test, since we salt temp file names? 

Comment 28

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED using the 2001-07-23-03-0.9.2 branch build on JFD's machine
(which was setup to view temp files).