Closed Bug 894683 Opened 9 years ago Closed 9 years ago

DPI reporting off by factor of 1000 on gonk-jb

Categories

(Core Graveyard :: Widget: Gonk, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file)

I screwed this up in the gonk-jb port. dbaron helped me figure out that the widget backend was reporting an improbable dpi. The wrong dpi causes the font inflation logic to break sites like nytimes.
Attachment #776773 - Flags: review?(vladimir)
Comment on attachment 776773 [details] [diff] [review]
Fix dpi reporting on gonk-jb

/ 1000.0f for sanity (though I don't know the type of values[2]...)
Attachment #776773 - Flags: review?(vladimir) → review+
values[2] is an int.
https://hg.mozilla.org/mozilla-central/rev/97222fa19573
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Looks like this patch is making font size too small in settings app and also browser urlinput bar stops working with this patch. I tested with jb_gonk and WVGA display.
Hi michael,

Is there any other dependency of this patch https://hg.mozilla.org/mozilla-central/rev/97222fa19573? 

Thanks
Flags: needinfo?(mwu)
I don't think so. Is the hwc module reporting the dpi correctly?
Flags: needinfo?(mwu)
Also, if you're testing on a tablet, the dpi there may violate some assumptions we have in our code which tend towards assuming phone sized devices. At any rate, it would be good to sanity check the dpi value being reported.
(I'm pretty sure Tapas is not using a tablet)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.