894683 - DPI reporting off by factor of 1000 on gonk-jb

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix dpi reporting on gonk-jb

I screwed this up in the gonk-jb port. dbaron helped me figure out that the widget backend was reporting an improbable dpi. The wrong dpi causes the font inflation logic to break sites like nytimes.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 776773 [details] [diff] [review]
Fix dpi reporting on gonk-jb

/ 1000.0f for sanity (though I don't know the type of values[2]...)

Comment 2

[Michael Wu [:mwu]]

values[2] is an int.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/projects/birch/rev/97222fa19573

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/97222fa19573

Comment 5

[Tapas[:tkundu on #b2g/gaia/memshrink/gfx] (always NI me)]

Looks like this patch is making font size too small in settings app and also browser urlinput bar stops working with this patch. I tested with jb_gonk and WVGA display.

Comment 6

[Tapas[:tkundu on #b2g/gaia/memshrink/gfx] (always NI me)]

Hi michael,

Is there any other dependency of this patch https://hg.mozilla.org/mozilla-central/rev/97222fa19573? 

Thanks

Comment 7

[Michael Wu [:mwu]]

I don't think so. Is the hwc module reporting the dpi correctly?

Comment 8

[Michael Wu [:mwu]]

Also, if you're testing on a tablet, the dpi there may violate some assumptions we have in our code which tend towards assuming phone sized devices. At any rate, it would be good to sanity check the dpi value being reported.

Comment 9

[Michael Vines [:m1] [:evilmachines]]

(I'm pretty sure Tapas is not using a tablet)