Disable Watchdog thread entirely on b2g18

RESOLVED WONTFIX

Status

()

defect
RESOLVED WONTFIX
6 years ago
6 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
x86
macOS
Points:
---

Firefox Tracking Flags

(blocking-b2g:leo+, firefox23 wontfix, firefox24 wontfix, firefox25 wontfix, b2g18 wontfix, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd wontfix)

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
sicking indicated in bug 870043 comment 31 that we'd probably prefer to just have no watchdog thread at all on b2g.

I've got some patches to re-architect the watchdog thread and make it prefable, but that's not going to be landable on b2g18. In the mean time, I think we can just do the dumb thing and #ifdef it out.
Assignee

Comment 2

6 years ago
This seems to have some odd failures on the try push, but it also seems like
nobody is pushing b2g18 stuff to try, since my try push seemed to bundle along
more than 2000 changesets to the try repo. Are these failures expected?
Attachment #776916 - Flags: superreview?(jonas)
Attachment #776916 - Flags: review?(mrbkap)
In general, pushing to b2g18 is a minefield, yes.
Attachment #776916 - Flags: review?(mrbkap) → review+
Attachment #776916 - Flags: superreview?(jonas) → superreview+
Assignee

Comment 4

6 years ago
https://hg.mozilla.org/releases/mozilla-b2g18/rev/13a54f1eac4f

I realized after pushing that I probably should have gotten approval or something. But dougt says I should just leave it. needinfo-ing release mgmt to make sure they're in the loop here.
Flags: needinfo?(release-mgmt)
blocking-b2g18:leo+ is the approval you're looking for :)
blocking-b2g: --- → leo?
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/13a54f1eac4f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.1 QE5
Flags: needinfo?(akeybl)
Assignee

Comment 7

6 years ago
In a nutshell, the issue here is that we have a thread which, unless the phone is completely idle, wakes up once per second in order to (potentially) trigger the slow script dialog. This has been reported by partner QA as waking up very regularly when a music app is running, which in general is a battery drain.

In bug 870043 comment 31, sicking explains why we probably don't even want the watchdog at all on B2G:
* The parent process should never trigger the slow script dialog, because we wrote all the JS that runs there.
* All untrusted content runs out-of-process, which means that the user can still manually interrupt (and kill) and apps that hang.
Assignee

Comment 8

6 years ago
(Note that I've rewritten the watchdog and made it pref-controlled in bug 870043, but it's not the kind of low-risk fix we'd take on b2g18. The patch here simply removes the machinery at compile-time for Gonk builds).
we should take this to v1.1, blocking as uplift approval.
blocking-b2g: leo? → leo+
Flags: needinfo?(release-mgmt)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6)
> https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/13a54f1eac4f

Ryan - why did this get uplifted to v1.1hd without being hd+?
Flags: needinfo?(ryanvm)
Anything that lands on b2g18 is automatically merged to v1.1hd?
Flags: needinfo?(ryanvm)
lsblakk,
it was uplifted prematurely and by accident.  bholley gave reasons why we want this.  i needed info on akeybl asking if we should back out.
Assignee

Comment 13

6 years ago
We decided in an email thread that this wasn't worth the risk, and that it would be better to let it ride the trains.

Backing out for b2g18.

https://hg.mozilla.org/releases/mozilla-b2g18/rev/35cb56244e74
Flags: needinfo?(akeybl)
Resolution: FIXED → WONTFIX
You need to log in before you can comment on or make changes to this bug.