Last Comment Bug 894717 - typo "plase upgrade" in autoconf files
: typo "plase upgrade" in autoconf files
Status: RESOLVED FIXED
[mentor=mccr8][lang=sh]
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla25
Assigned To: Roberta
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-16 17:47 PDT by Andrew McCreight [:mccr8]
Modified: 2013-07-19 18:01 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix 'plase' typo in autoconf files. (2.42 KB, patch)
2013-07-19 09:20 PDT, Roberta
khuey: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2013-07-16 17:47:41 PDT
The string "This compiler would fail to build firefox, plase upgrade." (which should be "please upgrade") appears in four files.

http://mxr.mozilla.org/mozilla-central/search?string=plase%20upgrade&filter=[Pp]lase%20upgrade
Comment 1 Roberta 2013-07-19 07:41:46 PDT
Hi, 
I'd like to fix it.
Comment 2 Andrew McCreight [:mccr8] 2013-07-19 08:52:06 PDT
Great!  If you click on the MXR link, it will show you the four places that need to be fixed.  Do you have a copy of the Firefox mozilla-central source tree?  Are you familiar with the process of attaching patches to bugzilla?
Comment 3 Roberta 2013-07-19 09:16:06 PDT
Yes, thanks, I did it once. I hope I remember the steps correctly.
Comment 4 Roberta 2013-07-19 09:20:07 PDT
Created attachment 778514 [details] [diff] [review]
Fix 'plase' typo in autoconf files.
Comment 5 Andrew McCreight [:mccr8] 2013-07-19 10:20:17 PDT
Comment on attachment 778514 [details] [diff] [review]
Fix 'plase' typo in autoconf files.

Looks good to me, though technically this should get a build peer's review, so I'll kick it over to Kyle.
Comment 6 Andrew McCreight [:mccr8] 2013-07-19 10:47:54 PDT
Thanks for the patch!

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c6b968a895a
Comment 7 Ryan VanderMeulen [:RyanVM] 2013-07-19 18:01:44 PDT
https://hg.mozilla.org/mozilla-central/rev/6c6b968a895a

Note You need to log in before you can comment on or make changes to this bug.