typo "plase upgrade" in autoconf files

RESOLVED FIXED in mozilla25

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: Roberta)

Tracking

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=mccr8][lang=sh])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
The string "This compiler would fail to build firefox, plase upgrade." (which should be "please upgrade") appears in four files.

http://mxr.mozilla.org/mozilla-central/search?string=plase%20upgrade&filter=[Pp]lase%20upgrade
Whiteboard: [mentor=mccr8]

Updated

4 years ago
Whiteboard: [mentor=mccr8] → [mentor=mccr8][lang=sh]
(Assignee)

Comment 1

4 years ago
Hi, 
I'd like to fix it.
(Reporter)

Comment 2

4 years ago
Great!  If you click on the MXR link, it will show you the four places that need to be fixed.  Do you have a copy of the Firefox mozilla-central source tree?  Are you familiar with the process of attaching patches to bugzilla?
Assignee: nobody → r.deviti
(Assignee)

Comment 3

4 years ago
Yes, thanks, I did it once. I hope I remember the steps correctly.
(Assignee)

Comment 4

4 years ago
Created attachment 778514 [details] [diff] [review]
Fix 'plase' typo in autoconf files.
Attachment #778514 - Flags: review?(continuation)
(Reporter)

Comment 5

4 years ago
Comment on attachment 778514 [details] [diff] [review]
Fix 'plase' typo in autoconf files.

Looks good to me, though technically this should get a build peer's review, so I'll kick it over to Kyle.
Attachment #778514 - Flags: review?(continuation) → review?(khuey)
Attachment #778514 - Flags: review?(khuey) → review+
(Reporter)

Comment 6

4 years ago
Thanks for the patch!

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c6b968a895a
https://hg.mozilla.org/mozilla-central/rev/6c6b968a895a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.