Closed Bug 894746 Opened 6 years ago Closed 6 years ago

When a number in mach's footer status is truncated, it prints "D" instead of a digit

Categories

(Firefox Build System :: Mach Core, enhancement)

x86_64
Linux
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: dholbert, Assigned: gps)

Details

Attachments

(1 file)

STR:
 1. Run ./mach build on a clean source tree
 2. Wait for the footer line to appear.
 3. Resize your terminal such that one of the numbers in the directory-count at the far-right is truncated (e.g. if it says "DIRECTORIES: 40/77", resize it such that only the "4" is visible, or only "40/7")

ACTUAL RESULTS: The digit of the truncated number is replaced with "D", so it looks like this:
> TIER: base nspr nss js platform app SUBTIER: export libs tools DIRECTORIES: 40/D
>
> (Why is this a "D"? -----------------------------------------------------------^)

EXPECTED RESULTS: The non-clipped digit should be displayed normally (or if we really want to be smart, maybe we just refuse to print the number). I.e. it should look something like:
> TIER: base nspr nss js platform app SUBTIER: export libs tools DIRECTORIES: 40/7


This behavior is odd enough that I'm guessing it's not intentional...

I'm on Ubuntu 13.04 64-bit.
I can see this occurring on Terminal.app on OS X 10.7 as well.

Would this have something to do with the blessings library, or how mach builds the footer bar?

Might be an interesting first bug.
the footer is built in

BuildProgressFooter in python/mozbuild/mozbuild/mach_commands.py

I think I will try to read it to see what exactly it's doing. It's late - time to drink some tea
Good catch! That ought to be part[0:...], not arg.
Should be a FISA court rubber stamp review.
Attachment #777891 - Flags: review?(ted)
Assignee: nobody → gps
Attachment #777891 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/7ad49d2ecad5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.