Closed Bug 894776 Opened 11 years ago Closed 11 years ago

mozbuild's mozconfig_loader doesn't properly handle spaces in mozconfig commands

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [mach])

Attachments

(1 file, 1 obsolete file)

With python/mozbuild/mozbuild/mozconfig_loader, the following: ac_add_options --foo="bar baz" becomes: ------BEGIN_AC_OPTION --foo=bar ------END_AC_OPTION ------BEGIN_AC_OPTION baz ------END_AC_OPTION instead of ------BEGIN_AC_OPTION --foo=bar baz ------END_AC_OPTION
Blocks: 894763
Attachment #776912 - Attachment is obsolete: true
Attachment #776912 - Flags: review?(gps)
Component: mach → Build Config
Summary: mach doesn't properly handle spaces in mozconfig commands → mozbuild's mozconfig_loader doesn't properly handle spaces in mozconfig commands
Whiteboard: [mach]
Comment on attachment 776913 [details] [diff] [review] mach doesn't properly handle spaces in mozconfig commands Review of attachment 776913 [details] [diff] [review]: ----------------------------------------------------------------- Good catch.
Attachment #776913 - Flags: review?(gps) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: