894802 - [System] Status bar shows time when it is in lockscreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Sorry for no description. I just press enter when it shows auto correction.

version: gaia/master
STR:
1. reboot device
2. see clock on the top-right corner. this shouldn't be that.

The bug 834542 argues about the timing to show the time in the status bar. And in bug 834542 comment 6, Josh said the following requirement:

Strong preference:
- Leave clock off default Lock screen
- Leave clock off "Enter security code" screen
- Add clock to Emergency Call screens

Bug 834542 already fixed it. But bug 864516 removed partial code of patch of bug 834542 which causes this bug.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: first screen when device is rebooted

Screenshot of this bug.

note: it only happens when device is rebooted.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive,

Could you kindly help me to review my code?


This patch has done below items.

1. new method to enable timebar on status bar, which show/hide icon and start/stop timer
2. update test items for timebar display.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 778812 [details]
PR to master

See github comments before you merge.
Yuren please help to broadcast your lovely sinon here.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 778812 [details]
PR to master

Replied on github.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Alive, 

code updated, would you like to take a look again?
We still don't use sinon due to there's only one boolean I need, so I set this boolean to statusbar_test.js. And I also update the name of method as you suggested.

Thanks.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

WFM.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Merge to master.
https://github.com/mozilla-b2g/gaia/commit/a91ba72a035361afaa8c3b3eb932182cc2358e5d