894811 - Defect - first character gets dropped when typing into urlbar after opening a new tab

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: App Bar, defect)

Description

[Jonathan Wilde [:jwilde]]

Steps to reproduce:
- Press control-t to open a new tab -> cursor put in urlbar
- Character is typed into urlbar. -> first character will be put into urlbar, gets selected.
- Continue typing (because you don't catch that the character is selected). -> first character (which was selected) gets deleted and replaced with new text entered.

Expected result:
First character should not be highlighted and dropped; full text should be entered.

Actual result:
First character of new URL/search is dropped.

Comment 1

[Jonathan Wilde [:jwilde]]

Attachment: failing testcase

Comment 2

[Allison Naaktgeboren :ally]

Attachment: missing edit char

I didnt mess with the paste & go handler. While it sounds like we should pull it, it doesn't actually interact with this code path or this bug, so I am leery of mixing it into this bug. A nice followup item for kamil maybe?

I left the formatting I had to add along the way, to conform to the metro style guide.

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 787225 [details] [diff] [review]
missing edit char

Review of attachment 787225 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for filing the followup bug 902713 too!

Comment 4

[Allison Naaktgeboren :ally]

https://hg.mozilla.org/integration/fx-team/rev/7e0356305566

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Backed out for causing perma-orange on mochitest-mc tests:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_urlbar.js | caret ui active
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_urlbar.js | runTests: Task failed - Error: Timed out waiting for condition to be true at testCondition@chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js:356
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_urlbar.js | uncaught exception - NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIEditor.paste] at chrome://browser/content/ContextCommands.js:92
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_urlbar.js | bug: popup should be showing
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_urlbar.js | selection enabled
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_selection_urlbar.js | caret browsing enabled

https://hg.mozilla.org/integration/fx-team/rev/e9e92ac3a89c

Comment 6

[Matt Brubeck (:mbrubeck)]

I can reproduce the test failures with this patch, but I haven't yet figured out the exact cause.  However, I think this bug may be fixed already by bug 902713, so this patch might not be needed anymore.  Can anyone confirm this?