Closed Bug 894877 Opened 8 years ago Closed 8 years ago

permissions.js onRadioClick tries to pass a host string to SitePermissions.remove, needs to be an nsIURI instead

Categories

(Firefox :: Page Info Window, defect)

Product:
Firefox
Component:
Page Info Window
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 25

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
844 bytes, patch
jaws
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
bug 889770 all over again...
Attachment #777070 - Flags: review?(jaws)
Comment on attachment 777070 [details] [diff] [review]
patch

Review of attachment 777070 [details] [diff] [review]:
-----------------------------------------------------------------

Can you add a test for this?
Attachment #777070 - Flags: review?(jaws) → review+
Not easily... would probably take more time to write than it's worth it.
https://hg.mozilla.org/mozilla-central/rev/244ff7612e87
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.