Closed Bug 895015 Opened 6 years ago Closed 6 years ago

OdinMonkey: make asm.js entries show up builtin FF profiler

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Right now they don't because there is a regexp match and the asm.js entry doesn't match it.
Attachment #777242 - Flags: review?(bbouvier)
Comment on attachment 777242 [details] [diff] [review]
patch

Review of attachment 777242 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: js/src/ion/AsmJSLink.cpp
@@ +261,5 @@
>      resumePC_(NULL)
>  {
>      if (cx->runtime()->spsProfiler.enabled()) {
> +        // Use a profiler string that matches jsMatch regex in
> +        // browser/devtools/profiler/cleopatra/parserWorker.js.

parserWorker is actually contained in the js/ subdirectory, so it should be browser/devtools/profiler/cleopatra/js/parserWorker.js

::: js/src/vm/SPSProfiler.cpp
@@ +205,5 @@
>  const char*
>  SPSProfiler::allocProfileString(JSContext *cx, JSScript *script, JSFunction *maybeFun)
>  {
> +    // Note: this profiler string is regexp-matched by
> +    // browser/devtools/profiler/cleopatra/parserWorker.js.

Ditto.
Attachment #777242 - Flags: review?(bbouvier) → review+
https://hg.mozilla.org/mozilla-central/rev/27cea830532a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.