895049 - Really bad hang in the Places Tree View when doing a search in the History sidebar

Status: RESOLVED DUPLICATE of bug 490714

(Firefox :: Bookmarks & History, defect, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

See this profile for a snapshot of the hang, http://people.mozilla.com/~bgirard/cleopatra/#report=51c678d64083d0921813e09bb7a970d185295da0

The lowest part of the JS that the hang shows is at http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/treeView.js#50.

STR:
Have a pretty heavy Firefox profile
Open the History sidebar
Do a search for two words, I search for "site identity", but your search may be different
Watch as Firefox hangs.

Comment 1

[Marco Bonardo [:mak]]

yes, it has always been like that, it's completely synchronous and we have a long way in changing that.

Comment 2

[Marco Bonardo [:mak]]

oh well, I lied, it has been much worse in the past.

Comment 3

[Marco Bonardo [:mak]]

From the profile, 2,5 seconds are spent in querying SQLite and building the result. If the search word was very common in history this is not surprising, it may have generated many thousands results, we must build a node for each.
Then there's about 1 second spent in NtUserWaitMessage that I'm not sure what's waiting.

Comment 4

[Marco Bonardo [:mak]]

we could probably introduce some sort of paging, first 1000 results, then if depleted load all of them, at least we'd reduce the jank for the most common cases.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Marco Bonardo [:mak] from comment #4)
> we could probably introduce some sort of paging, first 1000 results, then if
> depleted load all of them, at least we'd reduce the jank for the most common
> cases.

Great! I think that would be a good thing even if the API was completely asynchronous and off-main-thread.