895108 - contacts fails to import vcard generated by Mac OS X AddressBook

Status: RESOLVED DUPLICATE of bug 883278

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently both gaia master and v1-train fail to import vcards exported from the Mac OS X AddressBook.

Debug suggests that the issue is an end-of-line character issue.  These vcards end in \r\n instead of just \n.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Example vcard causing issue.

Here is an example vcard exported from Mac OS X 10.8 AddressBook.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Sergi, are you aware of this issue?

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Pull request at https://github.com/mozilla-b2g/gaia/pull/11032

One line fix to strip the \r characters in splitLines().  Also a unit test exposing the issue.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Nominating for leo.  It seems like there could be many vcards out there using alternate line endings and when we hit this there is no feedback to the user.  The import just hangs until the app is killed.

Comment 5

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi Ben,

I believe this should be fixed by https://github.com/mozilla-b2g/gaia/pull/11048, which was just merged. Can you confirm? Its bug is https://bugzilla.mozilla.org/show_bug.cgi?id=883278

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 777372 [details]
Pull request at https://github.com/mozilla-b2g/gaia/pull/11032

Yep, the import works now that https://github.com/mozilla-b2g/gaia/pull/11048 has landed.  I think it might have been nice to keep these issues separated in different commits, but it probably doesn't matter if they are both going to be uplifted.  Thanks!

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Marking this as a dupe now that bug 883278 has landed.  Thanks again Sergi!