895137 - At debug-build startup: "JavaScript strict warning: chrome://browser/content/browser.js, line 10632: in strict mode code, functions may be declared only at top level or immediately within another function"

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Start a debug build. Watch the terminal-spew.

ACTUAL RESULTS:
This warning appears:
  JavaScript strict warning: chrome://browser/content/browser.js, line 10632: in
  strict mode code, functions may be declared only at top level or immediately
  within another function

If I visit  chrome://browser/content/browser.js and go to line 10632, it points to the function "updateSearchEngine", which was added last month for bug 860119, here:
  http://hg.mozilla.org/mozilla-central/rev/c164a4079878#l3.17

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

ugh, I missed that in the review, it may be changed to:
let updateSearchEngine = function() {

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1: use 'let'

Seems reasonable. Here's a patch to do that.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 777429 [details] [diff] [review]
fix v1: use 'let'

Review of attachment 777429 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I didn't expect a so quick turnaround :)

Comment 4

[Daniel Holbert [:dholbert]]

Thanks! Sanity-check try run, before landing:
  https://tbpl.mozilla.org/?tree=Try&rev=18790ca2b13c

Comment 5

[Mike de Boer [:mikedeboer]]

Daniel, thanks for catching this and pardon for making you spend time on it! Silly mistake on my part.

Patch looks good and tests are green :)

Comment 6

[Daniel Holbert [:dholbert]]

No worries!

Inbound is closed at the moment; setting checkin-needed so that a sheriff will land this at some point. (thanks in advance, sheriff!)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a5270b729e9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6a5270b729e9