Remove prlong.h inclusions from the tree

RESOLVED FIXED in mozilla25

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks 1 bug)

Trunk
mozilla25
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Posted patch Patch (v1)Splinter Review
Attachment #777402 - Flags: review?(Pidgeot18)
I don't suppose you could also take a thrashing to the LL_ macros used from prlong.h while you're at it: <http://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=regexp%3A%2F\bLL_%2F%20-path%3Ansprpub%2F%20-path%3Asecurity%2Fnss%2F>?
(In reply to comment #3)
> I don't suppose you could also take a thrashing to the LL_ macros used from
> prlong.h while you're at it:
> <http://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=regexp%3A%2F\bLL_%2F%20-path%3Ansprpub%2F%20-path%3Asecurity%2Fnss%2F>?

Would you object to me doing that in another bug?  These inclusions are unnecessary regardless.
FWIW a ton of this work was done in bug 795351 among others.
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> Would you object to me doing that in another bug?  These inclusions are
> unnecessary regardless.

Not at all.

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #5)
> FWIW a ton of this work was done in bug 795351 among others.

And like the mass prtypes-removal bug, uses of these macros tend to creep in every now and again.
(In reply to comment #6)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> > Would you object to me doing that in another bug?  These inclusions are
> > unnecessary regardless.
> 
> Not at all.

Bug 895168.

> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #5)
> > FWIW a ton of this work was done in bug 795351 among others.
> 
> And like the mass prtypes-removal bug, uses of these macros tend to creep in
> every now and again.

Yes.  :(  I think we need to stop including nspr.h to fix that.
Attachment #777402 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/mozilla-central/rev/d5390807c2ce
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.