Closed Bug 895141 Opened 12 years ago Closed 12 years ago

Remove prlong.h inclusions from the tree

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch (v1)
8.94 KB, patch
jcranmer
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch Patch (v1) — — Splinter Review
Attachment #777402 - Flags: review?(Pidgeot18)
I don't suppose you could also take a thrashing to the LL_ macros used from prlong.h while you're at it: <http://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=regexp%3A%2F\bLL_%2F%20-path%3Ansprpub%2F%20-path%3Asecurity%2Fnss%2F>?
(In reply to comment #3) > I don't suppose you could also take a thrashing to the LL_ macros used from > prlong.h while you're at it: > <http://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=regexp%3A%2F\bLL_%2F%20-path%3Ansprpub%2F%20-path%3Asecurity%2Fnss%2F>? Would you object to me doing that in another bug? These inclusions are unnecessary regardless.
FWIW a ton of this work was done in bug 795351 among others.
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4) > Would you object to me doing that in another bug? These inclusions are > unnecessary regardless. Not at all. (In reply to :Ehsan Akhgari (needinfo? me!) from comment #5) > FWIW a ton of this work was done in bug 795351 among others. And like the mass prtypes-removal bug, uses of these macros tend to creep in every now and again.
(In reply to comment #6) > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #4) > > Would you object to me doing that in another bug? These inclusions are > > unnecessary regardless. > > Not at all. Bug 895168. > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #5) > > FWIW a ton of this work was done in bug 795351 among others. > > And like the mass prtypes-removal bug, uses of these macros tend to creep in > every now and again. Yes. :( I think we need to stop including nspr.h to fix that.
Attachment #777402 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/mozilla-central/rev/d5390807c2ce
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: