Closed
Bug 895144
Opened 11 years ago
Closed 11 years ago
Treat asm.js functions as long lived and pre-tenure them
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.15 KB,
patch
|
terrence
:
review+
terrence
:
checkin+
|
Details | Diff | Splinter Review |
We assert that anything that flows into a FunctionBox is tenured: these are kept alive by the script so they cannot die at a minor GC, they may be singleton, baked into JIT scripts, etc.
Attachment #777403 -
Flags: review?(luke)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 777403 [details] [diff] [review] v0 Could you add a small comment explaining the assumption about FunctionBox?
Attachment #777403 -
Flags: review?(luke) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #777403 -
Attachment is obsolete: true
Attachment #777971 -
Flags: review+
Attachment #777971 -
Flags: checkin?(ryanvm)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Remember to qref this time.
Attachment #777971 -
Attachment is obsolete: true
Attachment #777971 -
Flags: checkin?(ryanvm)
Attachment #777972 -
Flags: review+
Attachment #777972 -
Flags: checkin?(ryanvm)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [checkin-needed]
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/73b694eac109
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [checkin-needed]
|
|
Assignee | |
Updated•11 years ago
|
Attachment #777972 -
Flags: checkin?(ryanvm) → checkin+
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/73b694eac109
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•