Closed Bug 895177 Opened 7 years ago Closed 7 years ago

GenerationalGC: Inline tracing for minor GC

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v0 (obsolete) — Splinter Review
Keeping in mind that crypto is busted at the moment, and without pdfjs, since bug 889682 hasn't landed yet:

before: 9301
after:  9766
Attachment #777446 - Flags: review?(jdemooij)
Comment on attachment 777446 [details] [diff] [review]
v0

Review of attachment 777446 [details] [diff] [review]:
-----------------------------------------------------------------

A lot nicer than the quick-and-dirty hacks I tried :)

::: js/src/gc/Nursery.cpp
@@ +644,5 @@
>      }
>      markStoreBuffer(&trc);
>      rt->newObjectCache.clearNurseryObjects(rt);
>  
> +

Nit: extra new line.
Attachment #777446 - Flags: review?(jdemooij) → review+
(In reply to Jan de Mooij [:jandem] from comment #1)
> Comment on attachment 777446 [details] [diff] [review]
> 
> A lot nicer than the quick-and-dirty hacks I tried :)
> 

Thanks Jan! I basically just grabbed your patch, changed the namespacing a bit, and switched the slot marking to use getSlotRange.
Attachment #777446 - Attachment is obsolete: true
Attachment #777976 - Flags: review+
Attachment #777976 - Flags: checkin?(ryanvm)
Whiteboard: [checkin-needed]
Attachment #777976 - Flags: checkin?(ryanvm) → checkin+
https://hg.mozilla.org/mozilla-central/rev/aa9cfaaaeff7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Blocks: 1507445
You need to log in before you can comment on or make changes to this bug.