895177 - GenerationalGC: Inline tracing for minor GC

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

Keeping in mind that crypto is busted at the moment, and without pdfjs, since bug 889682 hasn't landed yet:

before: 9301
after:  9766

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 777446 [details] [diff] [review]
v0

Review of attachment 777446 [details] [diff] [review]:
-----------------------------------------------------------------

A lot nicer than the quick-and-dirty hacks I tried :)

::: js/src/gc/Nursery.cpp
@@ +644,5 @@
>      }
>      markStoreBuffer(&trc);
>      rt->newObjectCache.clearNurseryObjects(rt);
>  
> +

Nit: extra new line.

Comment 2

[Terrence Cole [:terrence]]

Attachment: inline_minorgc_object_tracing-vCheckin.diff

(In reply to Jan de Mooij [:jandem] from comment #1)
> Comment on attachment 777446 [details] [diff] [review]
> 
> A lot nicer than the quick-and-dirty hacks I tried :)
> 

Thanks Jan! I basically just grabbed your patch, changed the namespacing a bit, and switched the slot marking to use getSlotRange.

Comment 3

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa9cfaaaeff7

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa9cfaaaeff7