895205 - app tests use mozApps-style callback to handle XMLHttpRequest errors

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

test_app_update.html and test_packaged_app_install.html use the same error callback to handle both navigator.mozApps and XMLHttpRequest errors, but the handler signatures for those objects are different, so the callback throws when called by an XMLHttpRequest:

2 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/apps/tests/test_app_update.html | uncaught exception - TypeError: this.error is undefined at http://mochi.test:8888/tests/dom/apps/tests/test_app_update.html:37

The fix is to use an XMLHttpRequest-style callback to handle XMLHttpRequest errors.  This change also uses an abort-specific callback to handle aborts to distinguish them from errors, makes the mozApps callback the same in both scripts for consistency, and makes some assert messages consistent with the functions they're in.

Try run:
  https://tbpl.mozilla.org/?tree=Try&rev=857224af2197

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: erm, let -> var

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 777519 [details] [diff] [review]
patch v2: erm, let -> var

Review of attachment 777519 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks Myk!

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 777519 [details] [diff] [review]
patch v2: erm, let -> var

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9ded7687cdf

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9ded7687cdf