Closed Bug 895205 Opened 7 years ago Closed 7 years ago

app tests use mozApps-style callback to handle XMLHttpRequest errors

Categories

(Core Graveyard :: DOM: Apps, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: myk, Assigned: myk)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch v1: fixes problem (obsolete) — Splinter Review
test_app_update.html and test_packaged_app_install.html use the same error callback to handle both navigator.mozApps and XMLHttpRequest errors, but the handler signatures for those objects are different, so the callback throws when called by an XMLHttpRequest:

2 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/apps/tests/test_app_update.html | uncaught exception - TypeError: this.error is undefined at http://mochi.test:8888/tests/dom/apps/tests/test_app_update.html:37

The fix is to use an XMLHttpRequest-style callback to handle XMLHttpRequest errors.  This change also uses an abort-specific callback to handle aborts to distinguish them from errors, makes the mozApps callback the same in both scripts for consistency, and makes some assert messages consistent with the functions they're in.

Try run:
  https://tbpl.mozilla.org/?tree=Try&rev=857224af2197
Attachment #777487 - Flags: review?(fabrice)
Attachment #777487 - Attachment is obsolete: true
Attachment #777487 - Flags: review?(fabrice)
Attachment #777519 - Flags: review?(fabrice)
Comment on attachment 777519 [details] [diff] [review]
patch v2: erm, let -> var

Review of attachment 777519 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks Myk!
Attachment #777519 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/b9ded7687cdf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.