895238 - cairo-qt fails at configure with bsdgrep or gnugrep --disable-perl-regexp

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

checking for /usr/local/bin/qmake-qt4... /usr/local/bin/qmake-qt4
usage: grep [-abcDEFGHhIiJLlmnOoPqRSsUVvwxZ] [-A num] [-B num] [-C[num]]
       [-e pattern] [-f file] [--binary-files=value] [--color=when]
       [--context[=num]] [--directories=action] [--label] [--line-buffered]
       [--null] [pattern] [file ...]
configure: error: * * * Unsupported Qt Version:

FreeBSD has GNU and BSD versions of grep(1):
- bsdgrep doesn't support -P option at all
- gnugrep in base doesn't support -P because there's no pcre
- textproc/gnugrep port supports -P only when built with PCRE option on;
  PCRE is not enabled by default and consequently not in binary packages

Also, -P is a GNU extension, not part of POSIX:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html

I couldn't find any other instances of -P in mozilla tree using:

  # github mirror
  $ git grep -E 'grep[^|;]+-[^ ]*P[[:alnum:]]*( |$)' origin/master

Comment 1

[Jan Beich]

Attachment: use [0-9] instead

No need to use \d over [:digit:] or even [0-9]. In case perl regex
are really desirable we can use perl/python binary.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b7afc083985

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1b7afc083985

Comment 4

[Jan Beich]

Comment on attachment 777553 [details] [diff] [review]
use [0-9] instead

[Approval Request Comment]
Chase bug 876043 to avoid regressing qt4 build downstream, probably
with non-GNU minimalistic userland.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1fa6d0bcd26f