Closed Bug 895238 Opened 7 years ago Closed 7 years ago
cairo-qt fails at configure with bsdgrep or gnugrep --disable-perl-regexp
checking for /usr/local/bin/qmake-qt4... /usr/local/bin/qmake-qt4 usage: grep [-abcDEFGHhIiJLlmnOoPqRSsUVvwxZ] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] configure: error: * * * Unsupported Qt Version: FreeBSD has GNU and BSD versions of grep(1): - bsdgrep doesn't support -P option at all - gnugrep in base doesn't support -P because there's no pcre - textproc/gnugrep port supports -P only when built with PCRE option on; PCRE is not enabled by default and consequently not in binary packages Also, -P is a GNU extension, not part of POSIX: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html I couldn't find any other instances of -P in mozilla tree using: # github mirror $ git grep -E 'grep[^|;]+-[^ ]*P[[:alnum:]]*( |$)' origin/master
No need to use \d over [:digit:] or even [0-9]. In case perl regex are really desirable we can use perl/python binary.
Attachment #777553 - Flags: review?(mh+mozilla)
Attachment #777553 - Flags: review?(mh+mozilla) → review+
Assignee: nobody → jbeich
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Comment on attachment 777553 [details] [diff] [review] use [0-9] instead [Approval Request Comment] Chase bug 876043 to avoid regressing qt4 build downstream, probably with non-GNU minimalistic userland.
Attachment #777553 - Flags: approval-mozilla-aurora?
Attachment #777553 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.