Closed
Bug 895238
Opened 12 years ago
Closed 12 years ago
cairo-qt fails at configure with bsdgrep or gnugrep --disable-perl-regexp
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox24 fixed, firefox25 fixed)
RESOLVED
FIXED
mozilla25
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
Attachments
(1 file)
1.07 KB,
patch
|
glandium
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
checking for /usr/local/bin/qmake-qt4... /usr/local/bin/qmake-qt4
usage: grep [-abcDEFGHhIiJLlmnOoPqRSsUVvwxZ] [-A num] [-B num] [-C[num]]
[-e pattern] [-f file] [--binary-files=value] [--color=when]
[--context[=num]] [--directories=action] [--label] [--line-buffered]
[--null] [pattern] [file ...]
configure: error: * * * Unsupported Qt Version:
FreeBSD has GNU and BSD versions of grep(1):
- bsdgrep doesn't support -P option at all
- gnugrep in base doesn't support -P because there's no pcre
- textproc/gnugrep port supports -P only when built with PCRE option on;
PCRE is not enabled by default and consequently not in binary packages
Also, -P is a GNU extension, not part of POSIX:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html
I couldn't find any other instances of -P in mozilla tree using:
# github mirror
$ git grep -E 'grep[^|;]+-[^ ]*P[[:alnum:]]*( |$)' origin/master
No need to use \d over [:digit:] or even [0-9]. In case perl regex
are really desirable we can use perl/python binary.
Attachment #777553 -
Flags: review?(mh+mozilla)
Updated•12 years ago
|
Attachment #777553 -
Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
Comment 2•12 years ago
|
||
Assignee: nobody → jbeich
Keywords: checkin-needed
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Comment on attachment 777553 [details] [diff] [review]
use [0-9] instead
[Approval Request Comment]
Chase bug 876043 to avoid regressing qt4 build downstream, probably
with non-GNU minimalistic userland.
Attachment #777553 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #777553 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 5•12 years ago
|
||
status-firefox24:
--- → fixed
status-firefox25:
--- → fixed
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•