Closed Bug 89529 Opened 23 years ago Closed 23 years ago

browser freezes on loading pages with flash, shockwave

Categories

(Core Graveyard :: Plug-ins, defect, P1)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
PowerPC
Mac System 9.x
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.3

People

(Reporter: shrir, Assigned: peterlubczynski-bugs)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [PDT+])

Attachments

(1 file)

patch to correctly handle OS 9 vs. OS X
322 bytes, patch
Details | Diff | Splinter Review 
something broke between 0702 and 0703 mac branch builds. The 0703 and onwards 
builds just freezes when I try to load any plugins page..shockwave or flash...
note: happens on quicktime, real also. Page just does not laod and mouse pointer 
stays busy. Have to force quit to restart.
This is mac only : changing OS
OS: Windows NT → Mac System 9.x
Hardware: PC → Macintosh
Ouch, my mistake. TARGET_CARBON isn't a platform, and it's always defined.
Therefore, the code inside never got executed. This is a regression cause by me
from the checkin in bug 85334. A ast minute changes I should have tested better.
This is probably the cause of a bunch of other problems. Since the other bug was
PDT+, seeing approval for this one.

Also seeking review and super review for one liner patch just attached.
Status: NEW → ASSIGNED
Keywords: regression
Priority: -- → P1
Whiteboard: [seeking reviews]
Target Milestone: --- → mozilla0.9.3
Unified diff with context next time, please. sr=sfraser

r=dcone
patch in trunk, made it before the tree closed so it should be in today's 8am
builds. Shrirang, please try Mac plugins today. Thanks!
Keywords: vtrunk
Whiteboard: [seeking reviews] → [fix in trunk]
PDT+ per plugin meeting
Whiteboard: [fix in trunk] → [fix-in-hand]PDT+
mac trunk 0706 looks fine with this fix. Things are back to normal. Plugins are 
behaving now.
Filed a new problem found in quicktime plugin. 
Patch is now in both the trunk and the branch, marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: vtrunk
Resolution: --- → FIXED
Whiteboard: [fix-in-hand]PDT+ → [PDT+]
Thanks for the fast turnaround on this and thanks to Tucson QA and Shrirang on
working to find this!
verified on mac trunk and branch bits 070904 070903 that this issue is 
fixed..phew !!
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: