89529 - browser freezes on loading pages with flash, shockwave

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[shrirang khanzode]

something broke between 0702 and 0703 mac branch builds. The 0703 and onwards 
builds just freezes when I try to load any plugins page..shockwave or flash...

Comment 1

[shrirang khanzode]

note: happens on quicktime, real also. Page just does not laod and mouse pointer 
stays busy. Have to force quit to restart.

Comment 2

[shrirang khanzode]

This is mac only : changing OS

Comment 3

[Peter Lubczynski]

Attachment: patch to correctly handle OS 9 vs. OS X

Comment 4

[Peter Lubczynski]

Ouch, my mistake. TARGET_CARBON isn't a platform, and it's always defined.
Therefore, the code inside never got executed. This is a regression cause by me
from the checkin in bug 85334. A ast minute changes I should have tested better.
This is probably the cause of a bunch of other problems. Since the other bug was
PDT+, seeing approval for this one.

Also seeking review and super review for one liner patch just attached.

Comment 5

[Simon Fraser [no longer active]]

Unified diff with context next time, please. sr=sfraser

Comment 6

[dcone (gone)]

r=dcone

Comment 7

[Peter Lubczynski]

patch in trunk, made it before the tree closed so it should be in today's 8am
builds. Shrirang, please try Mac plugins today. Thanks!

Comment 8

[Peter Lubczynski]

PDT+ per plugin meeting

Comment 9

[shrirang khanzode]

mac trunk 0706 looks fine with this fix. Things are back to normal. Plugins are 
behaving now.
Filed a new problem found in quicktime plugin. 

Comment 10

[Peter Lubczynski]

Patch is now in both the trunk and the branch, marking FIXED.

Comment 11

[lchiang]

Thanks for the fast turnaround on this and thanks to Tucson QA and Shrirang on
working to find this!

Comment 12

[shrirang khanzode]

verified on mac trunk and branch bits 070904 070903 that this issue is 
fixed..phew !!