Closed Bug 895307 Opened 11 years ago Closed 11 years ago
[SMS] should detect phone numbers when then word before it ends with a number
Unagi device v1-train 07/17 build: Gecko-2d17cfb Gaia-c506c50 Ref. ril STR 1. Create a new SMS with for example: 'Test1 600123123' 2. Send it EXPECTED The number is underlined and tapping or long tapping on it will bring up the corresponding options (Call, Create as a new contact, Add to an existing one). ACTUAL The number is not detected as a link so there are no options available when tapping or long tapping on it. Similar situations where solved by bug892480, but this is a new scenario.
Test Case in Moztrap: https://moztrap.mozilla.org/manage/case/9081/
KM - Mind if I take this one? This LinkHelper code is all mine anyway
Summary: [SMS] Number not detected as a link when the word before it ends with a number → [SMS] should detect phone numbers when then word before it ends with a number
KM: I had actually started to think about this solution before I even clicked over here, so this is what I had in mind - If you think of a different (perhaps better) approach, please feel free to make changes.
Corey: It's ok, I haven't start digging it deeply yet. Changing assignee.
Assignee: rexboy → gnarf37
Comment on attachment 777960 [details] [diff] [review] patch v1 This implementation looks good for me and I could not figure out any possible case could make it failed yet.
Attachment #777960 - Flags: review?(schung) → review+
Triage - partners would take this into leo.
blocking-b2g: leo? → leo+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Uplifted cbaae06aa3712dd632deb47fcf3c0ab4f58993ae to: v1-train: 5bd630604b48bf76975e8b3f625df6fae303a637
This has been verified, with unagi v1-train 07/24 build: Gecko-f94f793 Gaia-ef03c2b ref ril It is working fine when the word ends with a number and then there is a valid number. But it is still wrong when the number is first and then a word which starts with a number. Opening a new follow up for that case (bug897494)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.