Closed
Bug 895318
Opened 11 years ago
Closed 11 years ago
black boxing checkboxes look bad on windows
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
1.85 KB,
patch
|
vporof
:
review+
Optimizer
:
feedback+
|
Details | Diff | Splinter Review |
Apparently it looks bad on windows and needs a border: 0 in some part of the CSS. Follow up to bug 877686 comment 23
Assignee | ||
Comment 1•11 years ago
|
||
Don't have a windows box with me to test it out, but this is the fix recommended by Optimizer, based on what he has done before in the timeline addon.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #777657 -
Flags: review?(vporof)
Attachment #777657 -
Flags: feedback?(scrapmachines)
Comment 2•11 years ago
|
||
Comment on attachment 777657 [details] [diff] [review] v1 Review of attachment 777657 [details] [diff] [review]: ----------------------------------------------------------------- Based on the fact that if it works for my add-on, it should work here too :) (Although it will be night before I can actually test it and see if it works)
Attachment #777657 -
Flags: feedback?(scrapmachines) → feedback+
Comment 3•11 years ago
|
||
Comment on attachment 777657 [details] [diff] [review] v1 Review of attachment 777657 [details] [diff] [review]: ----------------------------------------------------------------- I would've used border: none, but ok.
Attachment #777657 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Will wait till someone can verify before landing.
Comment 5•11 years ago
|
||
I confirm, this fixes the issue.
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/dcf2afce5801
Whiteboard: [fixed-in-fx-team]
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dcf2afce5801
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Assignee | ||
Comment 8•11 years ago
|
||
Re-opening because this got backed out when the first black boxes UI stuff got backed out of fx-team. This change wasn't actually merged to m-c.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a47c4711bcd9
Whiteboard: [fixed-in-fx-team]
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a47c4711bcd9
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•