Closed Bug 895318 Opened 6 years ago Closed 6 years ago

black boxing checkboxes look bad on windows

Categories

(DevTools :: Debugger, defect)

25 Branch
x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

Apparently it looks bad on windows and needs a border: 0 in some part of the CSS.

Follow up to bug 877686 comment 23
Attached patch v1Splinter Review
Don't have a windows box with me to test it out, but this is the fix recommended by Optimizer, based on what he has done before in the timeline addon.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #777657 - Flags: review?(vporof)
Attachment #777657 - Flags: feedback?(scrapmachines)
Comment on attachment 777657 [details] [diff] [review]
v1

Review of attachment 777657 [details] [diff] [review]:
-----------------------------------------------------------------

Based on the fact that if it works for my add-on, it should work here too :)
(Although it will be night before I can actually test it and see if it works)
Attachment #777657 - Flags: feedback?(scrapmachines) → feedback+
Comment on attachment 777657 [details] [diff] [review]
v1

Review of attachment 777657 [details] [diff] [review]:
-----------------------------------------------------------------

I would've used border: none, but ok.
Attachment #777657 - Flags: review?(vporof) → review+
Will wait till someone can verify before landing.
I confirm, this fixes the issue.
https://hg.mozilla.org/mozilla-central/rev/dcf2afce5801
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Re-opening because this got backed out when the first black boxes UI stuff got backed out of fx-team. This change wasn't actually merged to m-c.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/a47c4711bcd9
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.