Closed Bug 895337 Opened 7 years ago Closed 7 years ago

define HAVE_TOOLCHAIN_SUPPORT_MSSE4_1 if using Visual Studio

Categories

(Firefox Build System :: General, defect)

x86
Windows 8
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Minimum reqiurement of Gecko is VS2010 or later which supports SSE4.1.  This define needs for webrtc/libyuv SSE4.1 optimization.

To turn on SSE4.1 code on libyuv, we should define HAVE_TOOLCHAIN_SUPPORT_MSSE4_1 if using Visual Studio.
Attachment #777679 - Flags: review?(ted)
Comment on attachment 777679 [details] [diff] [review]
add HAVE_TOOLCHAIN_SUPPORT_MSSE4_1

Review of attachment 777679 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +2177,5 @@
> +        dnl both SSSE3 and SSE4.1.
> +        HAVE_TOOLCHAIN_SUPPORT_MSSSE3=1
> +        AC_SUBST(HAVE_TOOLCHAIN_SUPPORT_MSSSE3)
> +        HAVE_TOOLCHAIN_SUPPORT_MSSE4_1=1
> +        AC_SUBST(HAVE_TOOLCHAIN_SUPPORT_MSSE4_1)

Can you move these AC_SUBSTs (and the other ones up in the GCC block) down to the bottom of the file where most of them are? It's a little weird to have them in multiple places.
Attachment #777679 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/70669c459d46
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.