895378 - Hang on shutdown with media thread in MediaDecoderStateMachine::StopAudioThread

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[(not currently active) Ted Mielczarek]

Attachment: Stacks of all threads

I got a shutdown hang on Windows. The stacks from all threads are attached. padenot says the cause is obvious and he's working on a patch.

Comment 1

[Paul Adenot (:padenot)]

So, this is because we are trying to shutdown the thread when it is draining.

Here [1], if we receive a shutdown event when we are draining, we will never call the state callback to tell the BufferedAudioStream that it can consider the stream is drained, so it will keep waiting on the monitor ad vitam eternam.

[1]: http://mxr.mozilla.org/mozilla-central/source/media/libcubeb/src/cubeb_wasapi.cpp#290

Comment 2

[Paul Adenot (:padenot)]

Attachment: Send an DRAINED event when we are draining and shutdown is requested in the WASAPI cubeb backend. r=

Reproducing the problem would be pretty hard, but I'm convinced this would fix it.

Comment 3

[(not currently active) Ted Mielczarek]

Right, I can't tell you exactly what happened, except that I think I had a YouTube video (using <video>) queued up to play in a background tab, and I restarted for an update.

Comment 4

[Michael Wu [:mwu]]

https://hg.mozilla.org/projects/birch/rev/8ea7c73c9834

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8ea7c73c9834