Closed Bug 895390 Opened 6 years ago Closed 6 years ago

Intermittent browser_privatebrowsing_cache.js | Disk cache reports 0KB and has no entries - Got 1, expected 0

Categories

(Core :: Networking: Cache, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox24 --- unaffected
firefox25 --- disabled
firefox26 --- disabled
firefox27 --- fixed
firefox28 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: RyanVM, Assigned: mayhemer)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=25409989&tree=Mozilla-Inbound

Ubuntu VM 12.04 x64 mozilla-inbound opt test mochitest-browser-chrome on 2013-07-17 19:25:37 PDT for push 3fbd705d2328
slave: tst-linux64-ec2-077

19:32:11     INFO -  TEST-START | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_cache.js
19:32:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_cache.js | Disk cache reports 0KB and has no entries
19:32:12     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_cache.js | The private window got loaded
19:32:12     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_cache.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.org/" line: 0}]
19:32:12     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_cache.js | Memory cache reports some entries from example.org domain
19:32:12  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_cache.js | Disk cache reports 0KB and has no entries - Got 1, expected 0
19:32:12     INFO -  Stack trace:
19:32:12     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 536
19:32:12     INFO -      JS frame :: chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_cache.js :: get_cache_for_private_window/</</eventHandler/< :: line 111
19:32:12     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: testScope/test_executeSoon/<.run :: line 565
19:32:12     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
19:32:12     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_cache.js | finished in 751ms
There is either favicon.ico entry or http://127.0.0.1:8888/safebrowsing-dummy/newkey right at that moment in the cache.

The test must be rewritten to be more stable (i.e. selective on what it is testing).

I have to change the test for the new cache API that has changed (signatures as well as semantics).

I think we can way here for the new cache to land.
can wait
(In reply to Honza Bambas (:mayhemer) from comment #103)
> I think we can way here for the new cache to land.

Is that likely to make Fx26, or are we talking Fx27 more likely? Is there anything we can do for Fx25 besides just disabling the test?
I have this patch fixed on projects/gum right now.  When there is time (and there is not much) I can port the test back to m-c.  I think the test as is now on m-c is completely wrong since the APIs used to count the items are simply not counting what the test wants it to count.  The new cache API is smarter.
Test disabled until someone looks into the failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eca6dfcd51b
Whiteboard: [test disabled][leave open]
This test is fixed on gum and can be re-enabled after bug 913807 is landed, what I plan for tomorrow morning :)
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Depends on: 913807
(In reply to Ed Morley [:edmorley UTC+1] from comment #230)
> Test disabled until someone looks into the failures:

And Aurora.
https://hg.mozilla.org/releases/mozilla-aurora/rev/6b26687b1b1e
https://tbpl.mozilla.org/?tree=Try&rev=262dde2116e6

Seems like we can re-enable this test.  It has been changed as part of bug 913807 to be reliable.
Attachment #8335303 - Flags: review?(emorley)
Comment on attachment 8335303 [details] [diff] [review]
895390-re-enable-the-test.patch

:-)
Attachment #8335303 - Flags: review?(emorley) → review+
Comment on attachment 8335303 [details] [diff] [review]
895390-re-enable-the-test.patch

[Approval Request Comment]
This test had been fixed as part of bug 913807 that is now on Aurora too.  It is not in any way critical to re-enable the patch there, but when we uplift some cache/PB related stuff to aurora (e.g. some security fixes) it would be good to let this relatively important test run again to catch any privacy regressions.
Attachment #8335303 - Flags: approval-mozilla-aurora?
Attachment #8335303 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/8bd6eb01394e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [test disabled][leave open]
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.