Closed Bug 895433 Opened 7 years ago Closed 6 years ago

Fix some extraction bugs

Categories

(Calendar :: Lightning Only, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: merike, Assigned: merike)

Details

Attachments

(2 files)

No description provided.
Attached patch FixesSplinter Review
This fixes:
* finding next ordinal date correctly, previous logic was very odd (and only working in some cases), I cannot understand what I was thinking before :)
* error is logged if a pattern contains an empty variant, da locale fell into that trap already
* multi-word numbers didn't work
* some odd spaces in code
Attachment #777813 - Flags: review?(philipp)
Comment on attachment 777813 [details] [diff] [review]
Fixes

Review of attachment 777813 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I'm fine with pushing this to aurora too.
Attachment #777813 - Flags: review?(philipp)
Attachment #777813 - Flags: review+
Attachment #777813 - Flags: approval-calendar-aurora+
I found some more bugs in l10n comments :(
Attachment #798589 - Flags: review?(philipp)
Attachment #798589 - Flags: review?(philipp) → review+
Keywords: checkin-needed
Attachment #798589 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 798589 [details] [diff] [review]
l10n comments' bugs

a=philipp via irc
Attachment #798589 - Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+
Target Milestone: --- → 2.7
You need to log in before you can comment on or make changes to this bug.