895473 - [Mac and Linux] Custom distribution settings for yahoo de and es distributions are not being set

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

+++ This bug was initially created as a clone of Bug #882989 +++

Spinoff of bug 882989 for Mac and Linux.

The only method I can think of to fix on Mac and Linux this would be in the distribution code itself. This should be possible since on Mac and Linux we currently don't update unless the user updating has write access to the installation directory so after updating the user should have write access and the distribution.ini file can be encoded as utf-8 in distribution.js.

The error being thrown is:

Zeitstempel: 6/13/2013 5:50:05 PM
Fehler: [Exception... "Could not convert Native argument arg 2 [nsIINIParser.getString]"  nsresult: "0x8057000a (NS_ERROR_XPC_BAD_CONVERT_NATIVE)"  location: "JS frame :: resource://app/modules/distribution.js :: DIST_applyPrefDefaults :: line 269"  data: no]
Quelldatei: resource://app/modules/distribution.js
Zeile: 269

Comment 1

[Robert Strong (they/them - no direct email)]

One option that would protect against future encoding issues that would get us most of the way there would be to try / catch these calls. Then all but the name and name.AB_CD (e.g. yahoo.de) values would get set.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: wallpaper patch rev1

Hey Gavin, I came up with a wallpaper patch that should allow partner distributions with this bug to continue to work though the Partner's about string will not be display.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 778003 [details] [diff] [review]
wallpaper patch rev1

Looks fine to me, but mconnor said he'd review this on IRC.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 778003 [details] [diff] [review]
wallpaper patch rev1

r=me if you add a Cu.reportError(e); in the first try/catch.

I suspect a lot of this file could use defensive coding.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: wallpaper patch rev2 comments addressed

addressed comment and carrying forward r+

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/1273e2556a0f

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 778633 [details]
wallpaper patch rev2 comments addressed

[Approval Request Comment]
Bug caused by (feature/regressing bug #): No Bug. Specific partner distributions have been shipping ANSI encoded distribution.ini files which is incorrect.
User impact if declined: The affected partner distribution won't have all of their customizations set.
Testing completed (on m-c, etc.): Tested locally. Very little value in testing on m-c, etc. since this bug only affects these partner distributions.
Risk to taking this patch (and alternatives if risky): Low. The patch simply wraps the calls that throw in a try / catch
String or IDL/UUID changes made by this patch: None

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/51b93baa190b

Pushed to mozilla-beta
https://hg.mozilla.org/releases/mozilla-beta/rev/bc0f5e676268

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1273e2556a0f