Closed Bug 895473 Opened 6 years ago Closed 6 years ago

[Mac and Linux] Custom distribution settings for yahoo de and es distributions are not being set

Categories

(Firefox :: General, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 25
Tracking Status
firefox22 + wontfix
firefox23 + fixed
firefox24 + fixed
firefox25 --- fixed

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #882989 +++

Spinoff of bug 882989 for Mac and Linux.

The only method I can think of to fix on Mac and Linux this would be in the distribution code itself. This should be possible since on Mac and Linux we currently don't update unless the user updating has write access to the installation directory so after updating the user should have write access and the distribution.ini file can be encoded as utf-8 in distribution.js.

The error being thrown is:

Zeitstempel: 6/13/2013 5:50:05 PM
Fehler: [Exception... "Could not convert Native argument arg 2 [nsIINIParser.getString]"  nsresult: "0x8057000a (NS_ERROR_XPC_BAD_CONVERT_NATIVE)"  location: "JS frame :: resource://app/modules/distribution.js :: DIST_applyPrefDefaults :: line 269"  data: no]
Quelldatei: resource://app/modules/distribution.js
Zeile: 269
One option that would protect against future encoding issues that would get us most of the way there would be to try / catch these calls. Then all but the name and name.AB_CD (e.g. yahoo.de) values would get set.
Attached patch wallpaper patch rev1 (obsolete) — Splinter Review
Hey Gavin, I came up with a wallpaper patch that should allow partner distributions with this bug to continue to work though the Partner's about string will not be display.
Attachment #778003 - Flags: review?(gavin.sharp)
Comment on attachment 778003 [details] [diff] [review]
wallpaper patch rev1

Looks fine to me, but mconnor said he'd review this on IRC.
Attachment #778003 - Flags: review?(gavin.sharp) → review?(mconnor)
Comment on attachment 778003 [details] [diff] [review]
wallpaper patch rev1

r=me if you add a Cu.reportError(e); in the first try/catch.

I suspect a lot of this file could use defensive coding.
Attachment #778003 - Flags: review?(mconnor) → review+
addressed comment and carrying forward r+
Assignee: nobody → robert.bugzilla
Attachment #778003 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #778633 - Flags: review+
Comment on attachment 778633 [details]
wallpaper patch rev2 comments addressed

[Approval Request Comment]
Bug caused by (feature/regressing bug #): No Bug. Specific partner distributions have been shipping ANSI encoded distribution.ini files which is incorrect.
User impact if declined: The affected partner distribution won't have all of their customizations set.
Testing completed (on m-c, etc.): Tested locally. Very little value in testing on m-c, etc. since this bug only affects these partner distributions.
Risk to taking this patch (and alternatives if risky): Low. The patch simply wraps the calls that throw in a try / catch
String or IDL/UUID changes made by this patch: None
Attachment #778633 - Flags: approval-mozilla-beta?
Attachment #778633 - Flags: approval-mozilla-aurora?
Attachment #778633 - Flags: approval-mozilla-beta?
Attachment #778633 - Flags: approval-mozilla-beta+
Attachment #778633 - Flags: approval-mozilla-aurora?
Attachment #778633 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/1273e2556a0f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 900925
You need to log in before you can comment on or make changes to this bug.