895482 - Tags in Popcorn Maker should be included with remix

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Jacob [:Jacob]]

Right now when you remix a Popcorn Maker project, the tags from the original aren't included with the remix.

We should include the tags in the Project tab by default and allow the user to change them if they want, but at least have them there to start.

This will help us in better tracking remixes and trends based on tags that the original author uses.

Also, if possible, if we tag something ourselves in the Make Editor, for those tags to carry over into a remix.

Comment 1

[Kat Braybrooke [:codekat]]

+1 :)

Comment 2

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/143/files

For some reason I'm guessing jbuck might want to weigh in.

Comment 3

[Jon Buckley [:jbuck]]

Comment on attachment 783238 [details]
https://github.com/mozilla/popcorn.webmaker.org/pull/143/files

I made some notes in the pull request about using next() instead of responding directly.

Comment 4

[Matthew Schranz [:mjschranz]]

Comment on attachment 783238 [details]
https://github.com/mozilla/popcorn.webmaker.org/pull/143/files

Fixed up. Probably don't need to Jon to review again, especially since he's PTO for the rest of the week.

Comment 5

[Scott [:thecount] Downe]

Bug STR:

1. Create a project. (I had a single text event added, nothing else)
2. remix it.
3. save it.
4. refresh that page.

Expected: It should refresh that saved project, which now lives under a /edit url.
Actual: crashes popcorn maker:

TypeError: Object function ( app, options ) {
  module.exports = require("webmaker-loginapi")( app, options );
} has no method 'getUser'
    at /home/scott/popcorn.webmaker.org/lib/middleware.js:78:23
    at /home/scott/popcorn.webmaker.org/lib/project.js:130:9
    at null.<anonymous> (/home/scott/popcorn.webmaker.org/node_modules/sequelize/lib/emitters/custom-event-emitter.js:40:43)
    at EventEmitter.emit (events.js:95:17)
    at null.<anonymous> (/home/scott/popcorn.webmaker.org/node_modules/sequelize/lib/query-interface.js:291:17)
    at EventEmitter.emit (events.js:95:17)
    at module.exports.onSuccess (/home/scott/popcorn.webmaker.org/node_modules/sequelize/lib/dialects/sqlite/query.js:138:10)
    at Statement.<anonymous> (/home/scott/popcorn.webmaker.org/node_modules/sequelize/lib/dialects/sqlite/query.js:39:55)
--> in Database#all('SELECT * FROM `Projects` WHERE `Projects`.`id`=29;', [Function])
    at executeSql (/home/scott/popcorn.webmaker.org/node_modules/sequelize/lib/dialects/sqlite/query.js:35:52)
    at Statement.<anonymous> (/home/scott/popcorn.webmaker.org/node_modules/sequelize/lib/dialects/sqlite/query.js:54:13)

Comment 6

[Matthew Schranz [:mjschranz]]

Comment on attachment 783238 [details]
https://github.com/mozilla/popcorn.webmaker.org/pull/143/files

Fixed up.

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 783238 [details]
https://github.com/mozilla/popcorn.webmaker.org/pull/143/files

Yeah, this seems to be good now.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/52afc2e17955bdfa2ce89b6690afe18d755eac07
Fix Bug 895482 - Have a projects tags cascade to remixes. Refactor some server code

Comment 9

[Matthew Schranz [:mjschranz]]

Needs verify.