Closed
Bug 895489
Opened 11 years ago
Closed 11 years ago
Fix webapprt-test-chrome warnings
Categories
(Firefox Graveyard :: Web Apps, defect)
Firefox Graveyard
Web Apps
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: marco, Assigned: marco)
Details
Attachments
(1 file, 2 obsolete files)
1.86 KB,
patch
|
marco
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #777903 -
Flags: review?(fabrice)
Assignee | ||
Comment 1•11 years ago
|
||
See bug 894979 comment 3 for reference.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Assignee | ||
Comment 2•11 years ago
|
||
Oops, typo fix :)
Attachment #777903 -
Attachment is obsolete: true
Attachment #777903 -
Flags: review?(fabrice)
Attachment #777932 -
Flags: review?(fabrice)
Updated•11 years ago
|
Attachment #777932 -
Attachment is patch: true
Comment 3•11 years ago
|
||
Comment on attachment 777932 [details] [diff] [review] fix webapprt chrome warnings Review of attachment 777932 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/apps/src/AppDownloadManager.jsm @@ +58,5 @@ > * @return The opaque object representing the download. > */ > get: function app_dlMgr_get(aManifestURL) { > debug("Getting " + aManifestURL); > + if (!(aManifestURL in this.downloads)) { if (!this.downloads[aManifestURL]) is faster.
Attachment #777932 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Carrying r+.
Attachment #777932 -
Attachment is obsolete: true
Attachment #778155 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/077d190b7ab3
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/077d190b7ab3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•