Closed Bug 895489 Opened 6 years ago Closed 6 years ago

Fix webapprt-test-chrome warnings

Categories

(Firefox Graveyard :: Web Apps, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: marco, Assigned: marco)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch fix_webapprt_chrome_warnings (obsolete) — Splinter Review
No description provided.
Attachment #777903 - Flags: review?(fabrice)
See bug 894979 comment 3 for reference.
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Attached patch fix webapprt chrome warnings (obsolete) — Splinter Review
Oops, typo fix :)
Attachment #777903 - Attachment is obsolete: true
Attachment #777903 - Flags: review?(fabrice)
Attachment #777932 - Flags: review?(fabrice)
Attachment #777932 - Attachment is patch: true
Comment on attachment 777932 [details] [diff] [review]
fix webapprt chrome warnings

Review of attachment 777932 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/src/AppDownloadManager.jsm
@@ +58,5 @@
>     * @return              The opaque object representing the download.
>     */
>    get: function app_dlMgr_get(aManifestURL) {
>      debug("Getting " + aManifestURL);
> +    if (!(aManifestURL in this.downloads)) {

if (!this.downloads[aManifestURL]) is faster.
Attachment #777932 - Flags: review?(fabrice) → review+
Carrying r+.
Attachment #777932 - Attachment is obsolete: true
Attachment #778155 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/077d190b7ab3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.