Closed Bug 895531 Opened 7 years ago Closed 7 years ago

Add support for webrtc pulseaudio backend on gonk

Categories

(Core :: WebRTC: Audio/Video, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
(originally attached to the wrong bug)

This requires the patch from bug 825112 first. It also flips some prefs to make things work. I used http://mozilla.github.io/webrtc-landing/gum_test.html to test. Tested on a Nexus 4.
Comment on attachment 778995 [details] [diff] [review]
Make webrtc work on Pulseaudio on gonk

Review of attachment 778995 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/src/init/all.js
@@ +197,4 @@
>  pref("media.navigator.video.default_fps",30);
>  pref("media.navigator.video.default_minfps",10);
>  pref("media.peerconnection.enabled", true);
> +pref("media.navigator.permission.disabled", true);

Was this included by mistake?

@@ +219,4 @@
>  pref("media.webvtt.enabled", false);
>  
>  // Whether to enable MediaSource support
> +pref("media.mediasource.enabled", true);

Ditto - was this intentional?
(In reply to Randell Jesup [:jesup] from comment #2)
> Comment on attachment 778995 [details] [diff] [review]
> Make webrtc work on Pulseaudio on gonk
> 
> Review of attachment 778995 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: modules/libpref/src/init/all.js
> @@ +197,4 @@
> >  pref("media.navigator.video.default_fps",30);
> >  pref("media.navigator.video.default_minfps",10);
> >  pref("media.peerconnection.enabled", true);
> > +pref("media.navigator.permission.disabled", true);
> 
> Was this included by mistake?
> 
> @@ +219,4 @@
> >  pref("media.webvtt.enabled", false);
> >  
> >  // Whether to enable MediaSource support
> > +pref("media.mediasource.enabled", true);
> 
> Ditto - was this intentional?

I just included all the extra pref flipping that I used to get things working. This patch isn't suitable/meant for review.
This is more suitable for review.

This ensures that audio_device_pulse_linux.h is always included if LINUX_PULSE is enabled. It also fixes the name of the library that is loaded.
Attachment #778995 - Attachment is obsolete: true
Attachment #793814 - Flags: review?(rjesup)
Attachment #793814 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/e3f5c8983672
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.