895531 - Add support for webrtc pulseaudio backend on gonk

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Comment 1

[Michael Wu [:mwu]]

Attachment: Make webrtc work on Pulseaudio on gonk

(originally attached to the wrong bug)

This requires the patch from bug 825112 first. It also flips some prefs to make things work. I used http://mozilla.github.io/webrtc-landing/gum_test.html to test. Tested on a Nexus 4.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 778995 [details] [diff] [review]
Make webrtc work on Pulseaudio on gonk

Review of attachment 778995 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/src/init/all.js
@@ +197,4 @@
>  pref("media.navigator.video.default_fps",30);
>  pref("media.navigator.video.default_minfps",10);
>  pref("media.peerconnection.enabled", true);
> +pref("media.navigator.permission.disabled", true);

Was this included by mistake?

@@ +219,4 @@
>  pref("media.webvtt.enabled", false);
>  
>  // Whether to enable MediaSource support
> +pref("media.mediasource.enabled", true);

Ditto - was this intentional?

Comment 3

[Michael Wu [:mwu]]

(In reply to Randell Jesup [:jesup] from comment #2)
> Comment on attachment 778995 [details] [diff] [review]
> Make webrtc work on Pulseaudio on gonk
> 
> Review of attachment 778995 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: modules/libpref/src/init/all.js
> @@ +197,4 @@
> >  pref("media.navigator.video.default_fps",30);
> >  pref("media.navigator.video.default_minfps",10);
> >  pref("media.peerconnection.enabled", true);
> > +pref("media.navigator.permission.disabled", true);
> 
> Was this included by mistake?
> 
> @@ +219,4 @@
> >  pref("media.webvtt.enabled", false);
> >  
> >  // Whether to enable MediaSource support
> > +pref("media.mediasource.enabled", true);
> 
> Ditto - was this intentional?

I just included all the extra pref flipping that I used to get things working. This patch isn't suitable/meant for review.

Comment 4

[Michael Wu [:mwu]]

Attachment: Make webrtc work on Pulseaudio on gonk, v2

This is more suitable for review.

This ensures that audio_device_pulse_linux.h is always included if LINUX_PULSE is enabled. It also fixes the name of the library that is loaded.

Comment 5

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e3f5c8983672

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e3f5c8983672