895549 - Flash when swipe closing tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

After I swipe close a tab, I see the old tab briefly flash back into place before its killed.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This happens when clicking on the 'X' to close a tab too. I'm seeing it on a Galaxy Q running 2.3, it feels very glitchy whenever I see it.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

This makes us reset our transforms when the view is recycled instead of when the animation ends.

I'm guessing this is from bug 868460, but I don't really see any changes there. Just moving things around. I suspected the setHasTransientState calls were the causing problems, but removing them didn't fix anything.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 780514 [details] [diff] [review]
Patch

Grr. qdiff is failing me. Not the right patch.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 780516 [details] [diff] [review]
Patch

Review of attachment 780516 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting, I added code in PropertyAnimator that sets any animated view as having transient state (looks for setHasTransientState() calls there) which would cause the animated views to not be recycled by TwoWayView (at least for API level 16 and later). Maybe there's a bug in TwoWayView. In any case, this is needed for older Android versions.

::: mobile/android/base/TabsTray.java
@@ +349,5 @@
>  
>          TabRow tab = (TabRow)view.getTag();
>          final int tabId = tab.id;
> +        if (mOriginalSize == 0)
> +            mOriginalSize = (isVertical ? view.getHeight() : view.getWidth());

Please add a comment explaining the assumption that all list items have the same size.

Comment 6

[Lucas Rocha (:lucasr)]

Maybe it's the case to uplift this to Aurora least?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - Does this happen on Beta or Release?

Comment 8

[Wesley Johnston (:wesj)]

I only see this on nightly.

Comment 9

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8d184e3879d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f8d184e3879d