Closed Bug 895549 Opened 6 years ago Closed 6 years ago

Flash when swipe closing tabs

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 25
Tracking Status
fennec 24+ ---

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(1 file, 1 obsolete file)

After I swipe close a tab, I see the old tab briefly flash back into place before its killed.
This happens when clicking on the 'X' to close a tab too. I'm seeing it on a Galaxy Q running 2.3, it feels very glitchy whenever I see it.
tracking-fennec: --- → ?
Attached patch Patch (obsolete) — Splinter Review
This makes us reset our transforms when the view is recycled instead of when the animation ends.

I'm guessing this is from bug 868460, but I don't really see any changes there. Just moving things around. I suspected the setHasTransientState calls were the causing problems, but removing them didn't fix anything.
Attachment #780514 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 780514 [details] [diff] [review]
Patch

Grr. qdiff is failing me. Not the right patch.
Attachment #780514 - Flags: review?(lucasr.at.mozilla)
Attached patch PatchSplinter Review
Attachment #780514 - Attachment is obsolete: true
Attachment #780516 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 780516 [details] [diff] [review]
Patch

Review of attachment 780516 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting, I added code in PropertyAnimator that sets any animated view as having transient state (looks for setHasTransientState() calls there) which would cause the animated views to not be recycled by TwoWayView (at least for API level 16 and later). Maybe there's a bug in TwoWayView. In any case, this is needed for older Android versions.

::: mobile/android/base/TabsTray.java
@@ +349,5 @@
>  
>          TabRow tab = (TabRow)view.getTag();
>          final int tabId = tab.id;
> +        if (mOriginalSize == 0)
> +            mOriginalSize = (isVertical ? view.getHeight() : view.getWidth());

Please add a comment explaining the assumption that all list items have the same size.
Attachment #780516 - Flags: review?(lucasr.at.mozilla) → review+
Maybe it's the case to uplift this to Aurora least?
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
OS: Linux → Android
Hardware: x86_64 → ARM
Wes - Does this happen on Beta or Release?
tracking-fennec: ? → 24+
I only see this on nightly.
https://hg.mozilla.org/mozilla-central/rev/f8d184e3879d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.