895565 - align the black box checkbox with the source label

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Even though we don't plan on showing the list of breakpoints when their source is black boxed, if we already have breakpoints on a source, the eyeball is still not aligned properly.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: v1

This aligns the eyeball with the source, however we still have the blue bar on the left. I don't see how we can get rid of the blue bar on the left without mucking with the _target and the contents setter in nasty ways. It just doesn't seem like there is a good solution without refactoring a bunch of SideMenuWidget code. Or maybe I'm just not grooving with the whole Widgets stuff still. Suggestions wanted.

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 780082 [details] [diff] [review]
v1

Review of attachment 780082 [details] [diff] [review]:
-----------------------------------------------------------------

The horizontal alignment is an easy fix, although the opposite of obvious. Here's a diff:

 .side-menu-widget-item-contents {
-  padding: 4px;
+  padding: 4px 0px;
 }

 .side-menu-widget-item-other {
   background: url(background-noise-toolbar.png), hsla(208,11%,27%, 0.65);
-  margin: 0 -4px;
-  -moz-padding-start: 5px;
+  -moz-margin-start: -22px;
 }

It doesn't completely remove the left blue bar because I think showing some of it actually looks pretty good. The 22px margin should be modified once the eyeball will be made smaller.

r+ with the above changes.

Comment 3

[Victor Porof [:vporof][:vp]]

(that's in widgets.css)

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: v2

Added stuff victor wanted, and rounded corners which we discussed on irc.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/integration/fx-team/rev/e1cd5c1fda45

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e1cd5c1fda45

Comment 7

[Girish Sharma [:Optimizer]]

FYI - they are actually not aligned on Windows - http://i.snag.gy/W3iUX.jpg

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Filed bug 898063