Closed Bug 895565 Opened 6 years ago Closed 6 years ago

align the black box checkbox with the source label

Categories

(DevTools :: Debugger, defect)

25 Branch
x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: fitzgen, Assigned: fitzgen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Even though we don't plan on showing the list of breakpoints when their source is black boxed, if we already have breakpoints on a source, the eyeball is still not aligned properly.
Attached patch v1 (obsolete) — Splinter Review
This aligns the eyeball with the source, however we still have the blue bar on the left. I don't see how we can get rid of the blue bar on the left without mucking with the _target and the contents setter in nasty ways. It just doesn't seem like there is a good solution without refactoring a bunch of SideMenuWidget code. Or maybe I'm just not grooving with the whole Widgets stuff still. Suggestions wanted.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #780082 - Flags: review?(vporof)
Comment on attachment 780082 [details] [diff] [review]
v1

Review of attachment 780082 [details] [diff] [review]:
-----------------------------------------------------------------

The horizontal alignment is an easy fix, although the opposite of obvious. Here's a diff:

 .side-menu-widget-item-contents {
-  padding: 4px;
+  padding: 4px 0px;
 }

 .side-menu-widget-item-other {
   background: url(background-noise-toolbar.png), hsla(208,11%,27%, 0.65);
-  margin: 0 -4px;
-  -moz-padding-start: 5px;
+  -moz-margin-start: -22px;
 }

It doesn't completely remove the left blue bar because I think showing some of it actually looks pretty good. The 22px margin should be modified once the eyeball will be made smaller.

r+ with the above changes.
Attachment #780082 - Flags: review?(vporof) → review+
(that's in widgets.css)
Attached patch v2Splinter Review
Added stuff victor wanted, and rounded corners which we discussed on irc.
Attachment #780082 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/e1cd5c1fda45
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
FYI - they are actually not aligned on Windows - http://i.snag.gy/W3iUX.jpg
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.