Closed Bug 895567 Opened 7 years ago Closed 7 years ago

Defect - Start page flashes into view when navigating to a site

Categories

(Firefox for Metro Graveyard :: Firefox Start, defect, P1)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 25

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: feature=defect c=tbd u=tbd p=1)

Attachments

(1 file)

STR:

1) open metrofx
2) navigate to a site via a top site tile, let it load
3) nav back
4) navigate to the same site again

result: You'll see a flash where the page is displayed, then the start page comes back into view, then the page is displayed again.

This regressed in just the last day or so.

I'd suggest this block rollout, it really breaks the flow of navigating.
Summary: Start page flashes into view when navigating to a site → Defect - Start page flashes into view when navigating to a site
Whiteboard: feature=defect c=tbd u=tbd p=0
Priority: -- → P1
Assignee: nobody → jmathies
Blocks: metrov1it11
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=1
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
QA Contact: jbecerra
Attached patch fix v.1Splinter Review
I ditched the old BrowserUI.update constants which we weren't using and created a new one specific to controlling start ui visibility.
Attachment #780556 - Flags: review?(sfoster)
Comment on attachment 780556 [details] [diff] [review]
fix v.1

Review of attachment 780556 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, works well.

::: browser/metro/base/content/browser-ui.js
@@ +300,5 @@
> +   * the URL bar.
> +   */
> +  update: function(aFlags) {
> +    let flags = aFlags || 0;
> +    if (!(flags & this.NO_STARTUI_VISIBILITY)) {

Curious if you had other future flags in mind that led to this approach?
Attachment #780556 - Flags: review?(sfoster) → review+
(In reply to Sam Foster [:sfoster] from comment #2)
> Comment on attachment 780556 [details] [diff] [review]
> fix v.1
> 
> Review of attachment 780556 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, works well.
> 
> ::: browser/metro/base/content/browser-ui.js
> @@ +300,5 @@
> > +   * the URL bar.
> > +   */
> > +  update: function(aFlags) {
> > +    let flags = aFlags || 0;
> > +    if (!(flags & this.NO_STARTUI_VISIBILITY)) {
> 
> Curious if you had other future flags in mind that led to this approach?

I debated between a simple bool flag and this. since jwilde started with flags (despite not being in use) I decided to keep using that. Would you prefer something else?
https://hg.mozilla.org/mozilla-central/rev/d8b1f4688211
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:25.0) Gecko/20130729 Firefox/25.0

Verified as fixed on the latest Nightly build, following the steps from the description.
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.