If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Implement webmaker.org requirejs optimization

RESOLVED INVALID

Status

Webmaker
webmaker.org
RESOLVED INVALID
4 years ago
3 years ago

People

(Reporter: inactivate account for kate, Unassigned)

Tracking

Details

(Whiteboard: frontend, postfest, icebox)

(Reporter)

Description

4 years ago
Right now we are not running our js through requirejs optimization for production -- we should be.
Whiteboard: s=2013w30 p=1, frontend
(Reporter)

Updated

4 years ago
Whiteboard: s=2013w30 p=1, frontend → s=20130722 p=1, frontend

Comment 1

4 years ago
Bumping this, should be done by MozFest IMO
Whiteboard: s=20130722 p=1, frontend → mozfest

Updated

4 years ago
Assignee: kate → nobody
Dale, do you feel confident with this and Web Lit?
Assignee: nobody → dale

Comment 3

4 years ago
Yep!
Removing mozfest flag
Whiteboard: mozfest

Comment 5

4 years ago
Jon, can you help me come to a decision on our RequireJS optimization strategy?

You've wanted to use your middleware, but is this something we really need middleware for? I've had problems getting the middleware to work. I think including our RequireJS build step in grunt would make more sense; it's an action that we really only need to do once per deploy in production mode. JS won't be changing mid-deploy, so we shouldn't need to run each request through a middleware (unless I am mistaken in how Connect/ExpressJS middleware works).
Flags: needinfo?(jon)

Comment 6

4 years ago
If you can get the grunt task working, go for it, but it's just a blob of json either way to configure it.
Flags: needinfo?(jon)

Updated

4 years ago
Whiteboard: frontend, postfest

Updated

4 years ago
Assignee: dale → gavin

Updated

4 years ago
Duplicate of this bug: 934629

Updated

4 years ago
Assignee: gavin → nobody
Whiteboard: frontend, postfest → frontend, postfest, icebox
no longer relevant given current codebase
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Resolution: FIXED → INVALID
You need to log in before you can comment on or make changes to this bug.