895641 - [B2G][l10n][Marketplace] [ro]: localization needs to be updated

Status: RESOLVED WONTFIX

(Mozilla Localizations :: ro / Romanian, defect)

Description

[Peiying Mo [:CocoMo]]

Opening the bug to track progress of Romanian translation.  

Hi Alexandru, 

Based on the most recent stats, it appears there is little progress made in the Marketplace localization.  Let me know if there is anything that blocks you from doing the work.  We are here to help to remove obstacles so you can localize the content.   

Translation: Component, Priority and String Pickup Location:
===========
Marketplace consists of 3 components, Fireplace being the most important one and Zamboni as the legacy DB.  Zamboni is being revamped and redesigned.  The work is ongoing.
* P1: Fireplace - frontend, and consumer pages: https://github.com/mozilla/fireplace/tree/master/locale
* P2: Webpay - payment system: https://github.com/mozilla/webpay/tree/master/locale 
* P3: Zamboni (legacy): http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/locale/ 

For testing:
==========
* Overall test site: https://marketplace-dev.allizom.org/?lang=xx; for phones, change settings
* Webpay-paid apps: https://marketplace-dev.allizom.org/?lang=xx/search?q=pricepoint/

Thank you,
Peiying

Comment 1

[Raul Nicolae Malea]

Only in Github source for Fireplace and Webpay? Where is SVN source?
Also, I need SVN access here: http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/locale/ro/

This bug is for Marketplace website: https://marketplace-dev.allizom.org/ ?

Comment 2

[Francesco Lodolo [:flod]]

SVN is no more in use, see last mail sent to dev-l10n-web by Will.

For the record you already have access to that repository, but you need to use the right url (https://svn.mozilla.org)
https://svn.mozilla.org/addons/trunk/site/app/locale/ro/

Comment 3

[Raul Nicolae Malea]

Hmm...More, more accounts ...SVN, HG, Transifex, Verbatim, Narro .. now Github .... :(

Comment 4

[Francesco Lodolo [:flod]]

Or you can wait for Verbatim (the new version is able to talk with Git).

Comment 5

[Peiying Mo [:CocoMo]]

Hi Raul,

This is established now: https://github.com/mozilla/zamboni/tree/master/locale/ro/LC_MESSAGES.

All Marketplace components are on Git.  Here is a Git guideline. I hope it is helpful: https://help.github.com/articles/using-pull-requests.  If you need us to help with the submission, please attach the files in the bug.  Overall, it is good to familiarize yourself with Git as you may need to do it multiple times when you fix linguistic bugs.

Thank you,
Peiying

Comment 7

[Cristian Silaghi]

Can you import this in Verbatim? I don't know how to proceed with Github! This would be better for me!

Best Regards,
Cristian Silaghi!

Comment 8

[Peiying Mo [:CocoMo]]

Cristian, could you attach the file to this bug?

Comment 9

[Francesco Lodolo [:flod]]

It's a GetText file: download the .po file, translate it using tools like Virtaal or PoEdit and then attach it here as Peiying said (only the .po file).

When you're ready, needinfo me on this bug so that I'll remember to create the pull request for you.

Comment 10

[Cristian Silaghi]

Attachment: RO locale for Fireplace

I've translated Fireplace. You can see my work as attached. I hope everything is ok. :D I really don't have experience with .po files.

Francesco, can you submit file to Github? Thanks in advance!

Comment 11

[Raul Nicolae Malea]

Review:


(missing translate string):
#: hearth/templates/footer.html:24
msgid ""
"Except where otherwise <a href=\"{legal_url}\" target=\"_blank\">noted</a>, content on this site is licensed under the <a href=\"{cc_url}\" target=\"_blank\">Creative Commons Attribution Share-"
"Alike License v3.0</a> or any later version."
msgstr "Exceptând cazurile unde se <a href=\"{legal_url}\" target=\"_blank\">menționează</a>, altfel, conținutul din acest sait este licențiat sub licența <a href=\"{cc_url}\" target=\"_blank\">Creative Commons Attribution Share-"
"Alike License v3.0</a> sau orice altă versiune mai nouă."

(corrected):
#: hearth/templates/footer.html:30 hearth/templates/settings/feedback.html:27 hearth/templates/terms.html:2 hearth/media/js/views/terms.js:10
msgid "Terms of Use"
msgstr "Termenii de utilizare"

#: hearth/templates/ratings/report.html:18
msgid "Misplaced bug report or support request"
msgstr "Raportare de bug nepotrivită sau cerere asistență"

#: hearth/templates/search/main.html:7
msgid "<b>{n}</b> Result"
msgid_plural "<b>{n}</b> Results"
msgstr[0] "<b>{n}</b> rezultat"
msgstr[1] "<b>{n}</b> rezultate"

#: hearth/media/js/views/feedback.js:23
msgid "Feedback submitted. Thanks!"
msgstr "Opinie trimisă. Mulțumim!"

Cristian, please update your file. Thanks.

Comment 12

[Cristian Silaghi]

Attachment: messages.po

Translation updated thanks to Raul's suggestions.

Comment 13

[Francesco Lodolo [:flod]]

Cristian, the attached file has a problem.

In the header you state that Romanian uses 3 plural forms, but you only have two forms in plural strings.

msgid "{n} Review"
msgid "<b>{n}</b> Result"
msgid "{n} star"
msgid "<b>{n}</b> character left."

As I explained above, use a tool like PoEdit or Virtaal to check the file (PoEdit gives you an error on saving the file).

Comment 14

[Cristian Silaghi]

I didn't knew that, because I don't have experience with .po files. Can you fix that and comit to Github? The translation is ok so what you mentioned it is a technical issue. :D

Comment 15

[Cristian Silaghi]

I used Geany to translate the files. So I don't know what it's wrong with the file.

Comment 16

[Francesco Lodolo [:flod]]

No, I can't because I don't speak Romanian: you're missing the second plural form for 4 strings, so basically 4 translations.

These are free tools that you can use to translate .po files.
http://www.poedit.net/
http://virtaal.translatehouse.org/

Just open the .po file with them and it will be clear how to proceed. That's a pretty common format so it's better to understand how to deal with it ;-)

Comment 17

[Cristian Silaghi]

Attachment: messages.po

I've just changed to "Plural-Forms: nplurals=2; plural=(n > 1);\n" which I copied from French locale. Now the localization is ok and no error reported.

But I still don't know how to edit and Poedit just showed to me there's a problem aaand... that's all. :D

Comment 18

[Francesco Lodolo [:flod]]

Cristian, again: I don't speak Romanian, but this page says that your language uses 3 plural forms, not 2, so what you did it's just wrong.
https://developer.mozilla.org/en-US/docs/Localization_and_Plurals

1) Restore the correct plural rule (or download the previous attachment)
2) Open the .po file with PoEdit.
3) Search for the first string, click on it: on the bottom of the window you'll see 3 tabs, one for each plural form. Open the third one from the left (it's probably already open) and write your localization for that plural form.
4) Repeat for each string.
5) Save the file, you should have no errors from PoEdit this time.

If you still don't want to use PoEdit (but I can't see why), change those strings in the .po file like this (add a id[2] with the correct localization, and restore the correct plural rule in the header).

msgid "{n} Review"
msgid_plural "{n} Reviews"
msgstr[0] "{n} recenzie"
msgstr[1] "{n} recenzii"
msgstr[2] "{n} ????????"

Comment 19

[Cristian Silaghi]

Attachment: messages.po

Now it should be ok, I hope!

Comment 20

[Francesco Lodolo [:flod]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/fireplace/pull/231

Pointer to Github pull-request

Comment 21

[Cristian Silaghi]

So everything is now ok?

Comment 22

[Francesco Lodolo [:flod]]

The file looked ok to me, we need to wait and see if the pull request is good and can be merged ;-)

Comment 23

[Raul Nicolae Malea]

Translate are online now: https://marketplace-dev.allizom.org/?lang=ro/
Cristi, review please.

Comment 24

[Peiying Mo [:CocoMo]]

Cristian, please also take a screenshot for bug 899310, and send it to me or upload to a place that works for you. I can submit it on your behalf.

thanks,
Peiying

Comment 25

[Cristian Silaghi]

Peiyinh Mo, can you add Romania in Marketplace? I mean in "Region". I saw Hungary and Serbia and I would like to see also Romania.

Best Regards,
Cristian Silaghi

Comment 26

[Peiying Mo [:CocoMo]]

HI Cristian,

Marketplace already has an ro branch. You can see the status from here: http://l10n.mozilla-community.org/~flod/mpstats/.  The percentage, when complete, should be at 100%.

This is also enabled on the test site: https://marketplace-dev.allizom.org/?lang=ro/.

focus on Fireplace and Webpay first and work to complete Zamboni gradually.  It is a huge data base and it takes time to complete, but start working on it now.  


Let me know if this is what you are talking about.  

Thank you,
Peiying

Comment 27

[Cristian Silaghi]

Hi Peiying Mo,

I'm talking about setting the region in "Account Settings". I can see Hungary, Serbia and other few countries, but no Romania.

Best Regards,
Cristian Silaghi

Comment 28

[Peiying Mo [:CocoMo]]

Hi Cristian,

I have filed a ticket on this, and your finding impacts more than just Romania, so thanks for pointing it out.  Although the setting issue impacts both desktop and mobile, to view the apps landing page in ro shouldn't be a problem.  As soon as you change the language setting (under Setting, not part of the Marketplace), it will allow you to take screenshot for this particular bug request.

Let me know if you see something different.

Thanks,
Peiying

Comment 29

[Raul Nicolae Malea]

Cristian, any news for this? Thanks.

Comment 30

[Cristian Silaghi]

@Peiying, still no Romania in the list. :(

@Raul, no news. I will have a look to those files when I will have some time.

Best Regards,
Cristian Silaghi

Comment 31

[Peiying Mo [:CocoMo]]

Hi Cristian,

I did request the Marketplace team to add Romania to the list.  This is what I heard back.  Unless a phone carrier launches FFOS phone in Romania, it will not be added to the list of dropdown menu.  Currently Romanian (the language) is offered by some carriers as a language option, but not as a country.  The Marketplace country list is driven by where the phones are sold, but this list is not the same as the languages offered by many carriers combined.  Does it make sense?

Peiying

Comment 32

[Peiying Mo [:CocoMo]]

Hello Cristian,

There are still a lot of strings to be localized and it is an ongoing project.  Please keep an eye on the weekly status email from the Marketplace dev team.  In addition, you can track the status here: http://l10n.mozilla-community.org/~flod/mpstats/

Also for those not comfortable using github, contributors can go to verbatim to localize:
p1 front end: https://localize.mozilla.org/projects/fireplace/
p2 payment: https://localize.mozilla.org/projects/webpay/
p3 payment processor: https://localize.mozilla.org/projects/zippy/
p4 Zamboni (AMO): https://localize.mozilla.org/projects/amo/
p5 communication dashboard: https://localize.mozilla.org/projects/commbadge/
p6 publishing tool for developer: https://localize.mozilla.org/projects/rocketfuel/

The marketplace product is now serving both the FFOS, Android and desktop users.  Please keep this update. Thank you.

Removing bug 903145 from blocking the 1.1 release to allow it to catch up.

Comment 33

[Raul Nicolae Malea]

Cristian, any update? :P

Comment 34

[Raul Nicolae Malea]

Zippy are translate 100% by me in Verbatim. Fireplace are translated 46%.

Comment 35

[Raul Nicolae Malea]

Reminder for Romanian community and l10n team. :P

Comment 36

[Raul Nicolae Malea]

Jobava, help with that? You find these projects in comment 32. Thanks.

Comment 37

[Raul Nicolae Malea]

Bug resolved! Good! :)

Comment 38

[Jobava]

These all need another look-over, to catch anything amiss.

Comment 39

[Raul Nicolae Malea]

(In reply to Jobava from comment #38)
> These all need another look-over, to catch anything amiss.

Yes, but for moment this bug are closed. All projects are 100%.

Comment 40

[Jobava]

I need to read it all over again this evening, I will close the bug then, if you don't mind. Thanks.

Comment 41

[Peiying Mo [:CocoMo]]

Close the bug for now.  Let's shift our focus to the next generation of Marketplace.

Comment 42

[Raul Nicolae Malea]

Yep, I see in future from 11.08.2015. See comment 39. :)