895659 - Basic failure inside test_sanitySimpletest.html on b2g

Status: RESOLVED INVALID

(Testing :: Mochitest, defect)

Description

[[e-mail] [:onecyrenus]]

Basic test failure in test_sanitySimpletest.html
Trying to access a clipboard that is non existent in b2g. 

      SimpleTest.waitForClipboard("a",
        function () {
          SpecialPowers.clipboardCopyString("a");
        },
        function () {
          check = true;
        },
        function () {
          check = false;
        }
      );
      is(check, true, "waitForClipboard should work");

My recommended fix would be to move this test to another file, and only run on desktop.

Comment 1

[[e-mail] [:onecyrenus]]

Attachment: Bug895659.patch

This is an idea for a patch, haven't tested it as of yet, but would like to gather feedback before we go further. 
But the idea is to run desktop functionality on desktop and not gonk. 
This general approach can be applied to many tests where the functionality between desktop / b2g differ.

Comment 2

[[e-mail] [:onecyrenus]]

This is a harness test issue, please cc / add the requisite people on the bug.

Comment 3

[Jonathan Griffin (:jgriffin)]

This seems like a reasonable approach to me here. In other cases (in order to avoid too much duplication) we may want to skip b2g-specific tests by checking Services.appinfo.name (via SpecialPowers).

Comment 4

[Martijn Wargers (dead)]

Eventually, clipboard will become available for b2g, see bug 747798.
Wouldn't that mean, that test file would be able to work also on b2g?
Then the file would be have to moved back? Isn't an entry in the b2g.json file a better solution then?

Comment 5

[Jonathan Griffin (:jgriffin)]

It might be best to mark tests like this that fail as todo() if Services.appinfo.name == "B2G"; this will force the test to get updated when the affected code changes.

Comment 6

[Andrew Halberstadt [:ahal]]

Mass resolving of B2G mochitest bugs.