Closed Bug 895670 Opened 7 years ago Closed 7 years ago

Remove SetupScreen and associated assets

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 25

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

This is part of removing the profile migrator (Bug 886587).  I want to fold some related mobile/android/base/Makefile.in changes into this part, because with the death of setup_screen.xml comes the death of logo.png, which means I can finally kill some long-standing Makefile-badness.
There are two parts to this.  One is removing SetupScreen and its
assets, and that includes removing part of the profile migration
code.  This is not comprehensive; Bug 886587 will remove the remaining
profile migration code.

The second is deleting
$(MOZ_BRANDING_DIRECTORY)/**/android-resources.mn and removing
references to those manifests from mobile/android/base/Makefile.in;
this already got positive review under the name of Part 4 of Bug
892603.
Attachment #778137 - Flags: review?(mark.finkle)
Comment on attachment 778137 [details] [diff] [review]
Remove SetupScreen and associated assets. r=mfinkle

Kill these strings too:
splash_settingup
splash_bookmarks_history

Can we delete?:
branding/*/content/logo.png
branding/*/content/favicon32.png
Attachment #778137 - Flags: review?(mark.finkle) → review+
> Kill these strings too:
> splash_settingup
> splash_bookmarks_history

Good catch!  I had so many trees open, I killed these in the wrong buffer.
 
> Can we delete?:
> branding/*/content/logo.png

mxr says yes.

> branding/*/content/favicon32.png

Not trivially.  We could, with a little mucking about with the built in bookmark icon sizes and some testing code.

I'm going to land with these changes.
You need to log in before you can comment on or make changes to this bug.