895693 - sdk/notifications notify title option should accept numbers

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Comment 1

[Dave Townsend [:mossop]]

Seems like a rare case but yes we would take a fix for that.

Comment 2

[Tomislav Jovanovic :zombie]

Attachment: link to pr 1297

this was fairly simple, so besides `title` now accepting numbers, i fixed two other options: `text` also accepts numbers, and `iconURL` now accepts URL instances.

while looking at the nsIAlertService docs, i noticed two new arguments available since Firefox 22: `dir` and `lang` (along with `tag` which was already supported), so i added them to notification options.

https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIAlertsService

i don't know if these interface additions should be done in another bug (or at all), so i separated them in a second commit.

http://www.w3.org/TR/notifications/#api

and finally, our api is now very close Web Notification, so it might be a good idea to consider aligning with it completely (if possible).  again, maybe a separate bug?

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Looks good! Any chance we can split up the PR for the fix, and another for the extended features?

Comment 4

[Tomislav Jovanovic :zombie]

Comment on attachment 8333579 [details] [review]
link to pr 1297

done.  

will file a second bug for the api additions..

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a71988f72e39ea330810ad8a11f8b55d8f79c96b
bug 895693 - notify title, text accept numbers

and iconURL accepts URL instances.
plus a new test to confirm that.

https://github.com/mozilla/addon-sdk/commit/8b86d8bee5b80075f79dee0bd9579cfdc12c47a0
Merge pull request #1297 from zombie/895693-notif-options

Fix bug 895693 - fix notify title, text, iconURL validation, r=@jsantell